chrome/browser/ui/cocoa/view_id_util_browsertest.mm - Issue 1480183002: Deleted fullscreen virtual methods in BrowserWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

Issue 1480183002: Deleted fullscreen virtual methods in BrowserWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More Mac fixes. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/applescript/window_applescript.mm ('k') | chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc » ('j') | chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/view_id_util_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

index 5d99c136cc55bde9b009b2dfc600b07b3c5e52c8..24cc6c2128b31bc7359fb51d50f5f25392678886 100644

--- a/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

+++ b/chrome/browser/ui/cocoa/view_id_util_browsertest.mm

@@ -14,6 +14,8 @@

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_window.h"

#include "chrome/browser/ui/cocoa/view_id_util.h"

+#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"

+#include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"

#include "chrome/common/url_constants.h"

#include "chrome/test/base/in_process_browser_test.h"

#include "components/bookmarks/browser/bookmark_model.h"

@@ -97,7 +99,7 @@ IN_PROC_BROWSER_TEST_F(ViewIDTest, Basic) {

// Flaky on Mac: http://crbug.com/90557.

IN_PROC_BROWSER_TEST_F(ViewIDTest, DISABLED_Fullscreen) {

- browser()->window()->EnterFullscreen(

+ browser()->exclusive_access_manager()->context()->EnterFullscreen(

GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION,

false);

ASSERT_NO_FATAL_FAILURE(DoTest());