chrome/browser/ui/cocoa/applescript/window_applescript.mm - Issue 1480183002: Deleted fullscreen virtual methods in BrowserWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/applescript/window_applescript.mm

Issue 1480183002: Deleted fullscreen virtual methods in BrowserWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More Mac fixes. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/view_id_util_browsertest.mm » ('j') | chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/applescript/window_applescript.mm

diff --git a/chrome/browser/ui/cocoa/applescript/window_applescript.mm b/chrome/browser/ui/cocoa/applescript/window_applescript.mm

index e0874c64a3f73998d0e946718550da4821fbf656..022b334f0c02811d688a7cebfabfb86328076479 100644

--- a/chrome/browser/ui/cocoa/applescript/window_applescript.mm

+++ b/chrome/browser/ui/cocoa/applescript/window_applescript.mm

@@ -22,6 +22,8 @@

#include "chrome/browser/ui/cocoa/applescript/error_applescript.h"

#include "chrome/browser/ui/cocoa/applescript/metrics_applescript.h"

#import "chrome/browser/ui/cocoa/applescript/tab_applescript.h"

+#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"

+#include "chrome/browser/ui/exclusive_access/exclusive_access_manager.h"

#include "chrome/browser/ui/host_desktop.h"

#include "chrome/browser/ui/tab_contents/core_tab_helper.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

@@ -266,18 +268,14 @@

- (void)handlesEnterPresentationMode:(NSScriptCommand*)command {

AppleScript::LogAppleScriptUMA(

AppleScript::AppleScriptCommand::WINDOW_ENTER_PRESENTATION_MODE);

- if (browser_->window()) {

- browser_->window()->EnterFullscreen(

- GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_FULLSCREEN_EXIT_INSTRUCTION,

- false);

- }

+ browser_->exclusive_access_manager()->context()->EnterFullscreen(

+ GURL(), EXCLUSIVE_ACCESS_BUBBLE_TYPE_FULLSCREEN_EXIT_INSTRUCTION, false);

}

- (void)handlesExitPresentationMode:(NSScriptCommand*)command {

AppleScript::LogAppleScriptUMA(

AppleScript::AppleScriptCommand::WINDOW_EXIT_PRESENTATION_MODE);

- if (browser_->window())

- browser_->window()->ExitFullscreen();

+ browser_->exclusive_access_manager()->context()->ExitFullscreen();

}

@end