Investigate Android build problems in review 1414463004.

Investigate Android build problems in review 1414463004.

Do not merge this CL; its pure purpose is to identify why the tests refactored along
review 1414463004 won't succeed on linux_android_rel_ng.

[Timo Reimann, 2015-11-29 00:33:37]

Description was changed from

==========
Investigate Android build problems in review 1414463004.

Do not merge this CL; its pure purpose is to identify why the CL prepared along
review 1414463004 won't compile on linux_android_rel_ng.
==========

to

==========
I moved RemoveLoginsByOriginAndTimeImpl_FittingOriginAndTime back to
PasswordStoreDefaultTest in order to verify my hypothesis that the test
execution problems are related to a successful origin-based removal operation.

Vaclav, could you please fire off the linux_android_rel_ng try bot? Thanks!
==========

[Timo Reimann, 2015-11-29 00:33:37]

ttr314@googlemail.com changed reviewers:
+ vabr@chromium.org

[Timo Reimann, 2015-11-29 00:34:25]

Description was changed from

==========
I moved RemoveLoginsByOriginAndTimeImpl_FittingOriginAndTime back to
PasswordStoreDefaultTest in order to verify my hypothesis that the test
execution problems are related to a successful origin-based removal operation.

Vaclav, could you please fire off the linux_android_rel_ng try bot? Thanks!
==========

to

==========
Investigate Android build problems in review 1414463004.

Do not merge this CL; its pure purpose is to identify why the CL prepared along
review 1414463004 won't compile on linux_android_rel_ng.
==========

[Timo Reimann, 2015-11-29 00:34:52]

I moved RemoveLoginsByOriginAndTimeImpl_FittingOriginAndTime back to
PasswordStoreDefaultTest in order to verify my hypothesis that the test
execution problems are related to a successful origin-based removal operation.

Vaclav, could you please fire off the linux_android_rel_ng try bot? Thanks!

[Mike West, 2015-11-29 15:56:22]

The CQ bit was checked by mkwst@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-29 15:56:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1480153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1480153002/20001

[Timo Reimann, 2015-11-29 16:16:33]

Description was changed from

==========
Investigate Android build problems in review 1414463004.

Do not merge this CL; its pure purpose is to identify why the CL prepared along
review 1414463004 won't compile on linux_android_rel_ng.
==========

to

==========
Investigate Android build problems in review 1414463004.

Do not merge this CL; its pure purpose is to identify why the tests refactored
along
review 1414463004 won't succeed on linux_android_rel_ng.
==========

[commit-bot: I haz the power, 2015-11-29 17:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-29 17:06:40]

Dry run: This issue passed the CQ dry run.

[Timo Reimann, 2015-11-30 02:03:27]

On 2015/11/29 17:06:40, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

So the issue seems to be related to origin-specific passwords actually getting
removed (as the two tests left in PasswordStoreOriginTest do not fail). However,
it must also be relevant that I moved the store lifecycle (i.e., setup and
teardown) into the delegate because the test in question runs just fine in
PasswordStoreDefaultTest (which makes sense because that's what it was like
before my CL).

Will need to take another thorough look at the changes. Any further help or
pointers will be appreciated though.

[Timo Reimann, 2015-12-05 02:52:12]

Patchset #16 (id:300001) has been deleted

[vasilii, 2015-12-07 13:22:28]

vasilii@chromium.org changed reviewers:
+ vasilii@chromium.org

[vasilii, 2015-12-07 13:22:29]

https://codereview.chromium.org/1480153002/diff/320001/components/password_ma...
File components/password_manager/core/browser/password_store_default_unittest.cc
(right):

https://codereview.chromium.org/1480153002/diff/320001/components/password_ma...
components/password_manager/core/browser/password_store_default_unittest.cc:132:
store_ = nullptr;
null the pointer before running the loop.

[Timo Reimann, 2015-12-10 00:33:14]

Patchset #38 (id:760001) has been deleted

[Timo Reimann, 2015-12-10 06:58:53]

Patchset #39 (id:800001) has been deleted

[Timo Reimann, 2015-12-11 08:32:04]

Patchset #40 (id:840001) has been deleted

[vasilii, 2015-12-17 13:12:20]

The solution is that simple.

https://codereview.chromium.org/1480153002/diff/1040001/components/password_m...
File components/password_manager/core/browser/password_store_origin_unittest.h
(right):

https://codereview.chromium.org/1480153002/diff/1040001/components/password_m...
components/password_manager/core/browser/password_store_origin_unittest.h:92:
origin, base::Time::Time(), base::Time::Max(), base::Closure());
base::Time()