Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 1480153002: Investigate Android build problems in review 1414463004. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Add //url dep on GN test_support target. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_default.cc
diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc
index 7e3fac64e40c00bed59f3d091c777ddf292b2e82..481d6035010a3ef7010081c4299841d71f69d505 100644
--- a/components/password_manager/core/browser/password_store_default.cc
+++ b/components/password_manager/core/browser/password_store_default.cc
@@ -25,6 +25,7 @@ PasswordStoreDefault::PasswordStoreDefault(
}
PasswordStoreDefault::~PasswordStoreDefault() {
+ LOG(ERROR) << "~PasswordStoreDefault: deleting password store default";
}
bool PasswordStoreDefault::Init(
@@ -34,6 +35,7 @@ bool PasswordStoreDefault::Init(
}
void PasswordStoreDefault::ShutdownOnUIThread() {
+ LOG(ERROR) << "ShutdownOnUIThread: shutting down on UI thread";
PasswordStore::ShutdownOnUIThread();
ScheduleTask(base::Bind(&PasswordStoreDefault::ResetLoginDB, this));
}
@@ -58,9 +60,15 @@ void PasswordStoreDefault::ReportMetricsImpl(
PasswordStoreChangeList PasswordStoreDefault::AddLoginImpl(
const PasswordForm& form) {
+ VLOG(0) << "PasswordStoreDefault::AddLoginImpl: Started.";
DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());
- if (!login_db_)
+ if (!login_db_) {
+ VLOG(0) << "PasswordStoreDefault::AddLoginImpl: No login DB found -- "
+ "returning empty change list.";
return PasswordStoreChangeList();
+ }
+ VLOG(0)
+ << "PasswordStoreDefault::AddLoginImpl: Adding login to login database.";
return login_db_->AddLogin(form);
}
@@ -87,13 +95,21 @@ PasswordStoreChangeList PasswordStoreDefault::RemoveLoginsByOriginAndTimeImpl(
base::Time delete_end) {
ScopedVector<autofill::PasswordForm> forms;
PasswordStoreChangeList changes;
+ VLOG(0) << "PasswordStoreDefault::RemoveLoginsByOriginAndTimeImpl: Checking "
+ "for logins.";
if (login_db_ &&
login_db_->GetLoginsCreatedBetween(delete_begin, delete_end, &forms)) {
+ VLOG(0) << "PasswordStoreDefault::RemoveLoginsByOriginAndTimeImpl: Found "
+ "logins; trying to "
+ "match origin.";
for (autofill::PasswordForm* form : forms) {
if (origin.IsSameOriginWith(url::Origin(form->origin)) &&
- login_db_->RemoveLogin(*form))
+ login_db_->RemoveLogin(*form)) {
+ VLOG(0) << "PasswordStoreDefault::RemoveLoginsByOriginAndTimeImpl: "
+ "Login removed.";
changes.push_back(
PasswordStoreChange(PasswordStoreChange::REMOVE, *form));
+ }
}
if (!changes.empty())
LogStatsForBulkDeletion(changes.size());

Powered by Google App Engine
This is Rietveld 408576698