Investigate Android build problems in review 1414463004.

components/password_manager/core/browser/login_database.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/login_database.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 811 matching lines @@
                         &decrypted_password) == ENCRYPTION_RESULT_SUCCESS) {
       passwords_to_realms[decrypted_password].push_back(signon_realm);
     }
   }
 
   for (const auto& password_to_realms : passwords_to_realms)
     LogPasswordReuseMetrics(password_to_realms.second);
 }
 
 PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) {
+  VLOG(0) << "LoginDatabase::AddLogin: Started.";
   PasswordStoreChangeList list;
-  if (!DoesMatchConstraints(form))
+  if (!DoesMatchConstraints(form)) {
+    VLOG(0) << "LoginDatabase::AddLogin: Constraints not matching.";
     return list;
+  }
   std::string encrypted_password;
   if (EncryptedString(
           clear_password_values_ ? base::string16() : form.password_value,
-          &encrypted_password) != ENCRYPTION_RESULT_SUCCESS)
+          &encrypted_password) != ENCRYPTION_RESULT_SUCCESS) {
+    VLOG(0) << "LoginDatabase::AddLogin: Encryption failed.";
     return list;
+  }
 
+  VLOG(0) << "LoginDatabase::AddLogin: Preparing INSERT SQL statement.";
   // You *must* change LoginTableColumns if this query changes.
   sql::Statement s(db_.GetCachedStatement(
       SQL_FROM_HERE,
       "INSERT INTO logins "
       "(origin_url, action_url, username_element, username_value, "
       " password_element, password_value, submit_element, "
       " signon_realm, ssl_valid, preferred, date_created, blacklisted_by_user, "
       " scheme, password_type, possible_usernames, times_used, form_data, "
       " date_synced, display_name, icon_url,"
       " federation_url, skip_zero_click, generation_upload_status) VALUES "
       "(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"));
+  VLOG(0) << "LoginDatabase::AddLogin: Binding INSERT SQL parameters.";
   BindAddStatement(form, encrypted_password, &s);
   db_.set_error_callback(base::Bind(&AddCallback));
+  VLOG(0) << "LoginDatabase::AddLogin: Running INSERT SQL statement.";
   const bool success = s.Run();
   db_.reset_error_callback();
   if (success) {
+    VLOG(0) << "LoginDatabase::AddLogin: INSERT SQL operation succeeded.";
     list.push_back(PasswordStoreChange(PasswordStoreChange::ADD, form));
     return list;
   }
   // Repeat the same statement but with REPLACE semantic.
+  VLOG(0)
+      << "LoginDatabase::AddLogin: Adding failed -- trying REPLACE semantics.";
+
+  VLOG(0) << "LoginDatabase::AddLogin: Preparing REPLACE SQL statement.";
   s.Assign(db_.GetCachedStatement(
       SQL_FROM_HERE,
       "INSERT OR REPLACE INTO logins "
       "(origin_url, action_url, username_element, username_value, "
       " password_element, password_value, submit_element, "
       " signon_realm, ssl_valid, preferred, date_created, blacklisted_by_user, "
       " scheme, password_type, possible_usernames, times_used, form_data, "
       " date_synced, display_name, icon_url,"
       " federation_url, skip_zero_click, generation_upload_status) VALUES "
       "(?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"));
+
+  VLOG(0) << "LoginDatabase::AddLogin: Binding REPLACE SQL parameters.";
   BindAddStatement(form, encrypted_password, &s);
+  VLOG(0) << "LoginDatabase::AddLogin: Running REPLACE SQL statement.";
   if (s.Run()) {
+    VLOG(0) << "LoginDatabase::AddLogin: REPLACE SQL operation succeeded.";
     list.push_back(PasswordStoreChange(PasswordStoreChange::REMOVE, form));
     list.push_back(PasswordStoreChange(PasswordStoreChange::ADD, form));
   }
+  VLOG(0) << "LoginDatabase::AddLogin: Returning result.";
   return list;
 }
 
 PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) {
   std::string encrypted_password;
   if (EncryptedString(
           clear_password_values_ ? base::string16() : form.password_value,
           &encrypted_password) != ENCRYPTION_RESULT_SUCCESS)
     return PasswordStoreChangeList();
 
@@ skipping 57 matching lines @@
     return PasswordStoreChangeList();
 
   PasswordStoreChangeList list;
   if (db_.GetLastChangeCount())
     list.push_back(PasswordStoreChange(PasswordStoreChange::UPDATE, form));
 
   return list;
 }
 
 bool LoginDatabase::RemoveLogin(const PasswordForm& form) {
+  VLOG(0) << "LoginDatabase::RemoveLogin: Started.";
+
   if (form.is_public_suffix_match) {
     // TODO(dvadym): Discuss whether we should allow to remove PSL matched
     // credentials.
+    VLOG(0) << "LoginDatabase::RemoveLogin: Public suffix match exists.";
     return false;
   }
 #if defined(OS_IOS)
   DeleteEncryptedPassword(form);
 #endif
+  VLOG(0) << "LoginDatabase::RemoveLogin: Preparing SQL statement.";
   // Remove a login by UNIQUE-constrained fields.
   sql::Statement s(db_.GetCachedStatement(SQL_FROM_HERE,
                                           "DELETE FROM logins WHERE "
                                           "origin_url = ? AND "
                                           "username_element = ? AND "
                                           "username_value = ? AND "
                                           "password_element = ? AND "
                                           "submit_element = ? AND "
                                           "signon_realm = ? "));
+
+  VLOG(0) << "LoginDatabase::RemoveLogin: Binding SQL parameters.";
   s.BindString(0, form.origin.spec());
   s.BindString16(1, form.username_element);
   s.BindString16(2, form.username_value);
   s.BindString16(3, form.password_element);
   s.BindString16(4, form.submit_element);
   s.BindString(5, form.signon_realm);
 
+  VLOG(0) << "LoginDatabase::RemoveLogin: Running SQL statement.";
   return s.Run() && db_.GetLastChangeCount() > 0;
 }
 
 bool LoginDatabase::RemoveLoginsCreatedBetween(base::Time delete_begin,
                                                base::Time delete_end) {
 #if defined(OS_IOS)
   ScopedVector<autofill::PasswordForm> forms;
   if (GetLoginsCreatedBetween(delete_begin, delete_end, &forms)) {
     for (size_t i = 0; i < forms.size(); i++) {
       DeleteEncryptedPassword(*forms[i]);
@@ skipping 153 matching lines @@
   }
 
   return StatementToForms(&s, should_PSL_matching_apply ? &form : nullptr,
                           forms);
 }
 
 bool LoginDatabase::GetLoginsCreatedBetween(
     const base::Time begin,
     const base::Time end,
     ScopedVector<autofill::PasswordForm>* forms) const {
+  VLOG(0) << "LoginDatabase::GetLoginsCreatedBetween: Started.";
   DCHECK(forms);
+  VLOG(0) << "LoginDatabase::GetLoginsCreatedBetween: Preparing SQL statement.";
   sql::Statement s(db_.GetCachedStatement(
       SQL_FROM_HERE,
       "SELECT origin_url, action_url, "
       "username_element, username_value, "
       "password_element, password_value, submit_element, "
       "signon_realm, ssl_valid, preferred, date_created, blacklisted_by_user, "
       "scheme, password_type, possible_usernames, times_used, form_data, "
       "date_synced, display_name, icon_url, "
       "federation_url, skip_zero_click, generation_upload_status FROM logins "
       "WHERE date_created >= ? AND date_created < ?"
       "ORDER BY origin_url"));
+  VLOG(0) << "LoginDatabase::GetLoginsCreatedBetween: Binding SQL parameters.";
   s.BindInt64(0, begin.ToInternalValue());
   s.BindInt64(1, end.is_null() ? std::numeric_limits<int64>::max()
                                : end.ToInternalValue());
 
+  VLOG(0) << "LoginDatabase::GetLoginsCreatedBetween: Running SQL statement.";
   return StatementToForms(&s, nullptr, forms);
 }
 
 bool LoginDatabase::GetLoginsSyncedBetween(
     const base::Time begin,
     const base::Time end,
     ScopedVector<autofill::PasswordForm>* forms) const {
   DCHECK(forms);
   sql::Statement s(db_.GetCachedStatement(
       SQL_FROM_HERE,
@@ skipping 113 matching lines @@
     UMA_HISTOGRAM_ENUMERATION("PasswordManager.PslDomainMatchTriggering",
                               psl_domain_match_metric, PSL_DOMAIN_MATCH_COUNT);
   }
 
   if (!statement->Succeeded())
     return false;
   return true;
 }
 
 }  // namespace password_manager