components/password_manager/core/browser/password_store.h - Issue 1480153002: Investigate Android build problems in review 1414463004.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 1480153002: Investigate Android build problems in review 1414463004. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Add //url dep on GN test_support target. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_test_utils.cc ('k') | components/password_manager/core/browser/password_store.cc » ('j') | components/password_manager/core/browser/password_store_origin_unittest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store.h

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h

index 5b86f1e0ed315aea0c26fb238117df253c1fb5b9..78fe81a6c18781bb3b3d3f37ef95d92925e06a4c 100644

--- a/components/password_manager/core/browser/password_store.h

+++ b/components/password_manager/core/browser/password_store.h

@@ -186,7 +186,7 @@ class PasswordStore : protected PasswordStoreSync,

void GetSiteStats(const GURL& origin_domain, PasswordStoreConsumer* consumer);

// Adds an observer to be notified when the password store data changes.

- void AddObserver(Observer* observer);

+ bool AddObserver(Observer* observer);

// Removes |observer| from the observer list.

void RemoveObserver(Observer* observer);

@@ -248,7 +248,7 @@ class PasswordStore : protected PasswordStoreSync,

virtual PasswordStoreChangeList RemoveLoginsByOriginAndTimeImpl(

const url::Origin& origin,

base::Time delete_begin,

- base::Time delete_end);

+ base::Time delete_end) = 0;

// Synchronous implementation to remove the given logins.

virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(