Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1477353002: Revert of Move throttling of background timers into the renderer scheduler (Closed)

Created:
5 years ago by alex clarke (OOO till 29th)
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, rwlbuis, scheduler-bugs_chromium.org, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move throttling of background timers into the renderer scheduler (patchset #16 id:300001 of https://codereview.chromium.org/1441073006/ ) Reason for revert: Oops I'd meant to upload one final patchset before committing. Original issue's description: > Move throttling of background timers into the renderer scheduler > > Not only does this simplify the code, it's more efficent since > previously setting the timer alignment resulted in mass cancellation > and reposting of timers. > > BUG=510398, 546953, 560402 > > Committed: https://crrev.com/ec5adec0a9879a31866e98c65ddc7b506b9f49c3 > Cr-Commit-Position: refs/heads/master@{#361971} TBR=jochen@chromium.org,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510398, 546953, 560402 Committed: https://crrev.com/8f37a89f30c1ccafd36a86369ff2f3b63b251ea1 Cr-Commit-Position: refs/heads/master@{#361972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -849 lines) Patch
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/base/real_time_domain.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/scheduler/base/real_time_domain.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/base/task_queue.h View 4 chunks +8 lines, -6 lines 0 comments Download
M components/scheduler/base/task_queue.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/scheduler/base/task_queue_impl.h View 6 chunks +8 lines, -5 lines 0 comments Download
M components/scheduler/base/task_queue_impl.cc View 8 chunks +30 lines, -24 lines 0 comments Download
M components/scheduler/base/task_queue_manager.h View 3 chunks +9 lines, -6 lines 0 comments Download
M components/scheduler/base/task_queue_manager.cc View 6 chunks +11 lines, -8 lines 0 comments Download
M components/scheduler/base/task_queue_manager_unittest.cc View 10 chunks +80 lines, -45 lines 0 comments Download
M components/scheduler/base/task_queue_selector_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/scheduler/base/task_queue_sets_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M components/scheduler/base/time_domain.h View 4 chunks +5 lines, -24 lines 0 comments Download
M components/scheduler/base/time_domain.cc View 4 chunks +5 lines, -28 lines 0 comments Download
M components/scheduler/base/time_domain_unittest.cc View 5 chunks +10 lines, -50 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/scheduler/base/virtual_time_domain.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/scheduler/child/idle_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_helper.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/scheduler/child/scheduler_helper.cc View 1 chunk +6 lines, -18 lines 0 comments Download
M components/scheduler/child/web_scheduler_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/scheduler/child/web_scheduler_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.h View 4 chunks +0 lines, -17 lines 0 comments Download
M components/scheduler/renderer/renderer_scheduler_impl.cc View 5 chunks +1 line, -20 lines 0 comments Download
D components/scheduler/renderer/throttling_helper.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/scheduler/renderer/throttling_helper.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D components/scheduler/renderer/throttling_helper_unittest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.cc View 4 chunks +2 lines, -29 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.h View 3 chunks +2 lines, -5 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl.cc View 3 chunks +8 lines, -23 lines 0 comments Download
M components/scheduler/renderer/web_view_scheduler_impl_unittest.cc View 3 chunks +6 lines, -99 lines 0 comments Download
M components/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc View 1 chunk +10 lines, -13 lines 0 comments Download
M components/scheduler/scheduler.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimer.cpp View 2 chunks +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/SuspendableTimer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 2 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/NullExecutionContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/NullExecutionContext.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/Timer.cpp View 3 chunks +26 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/TimerTest.cpp View 2 chunks +79 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebScheduler.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alex clarke (OOO till 29th)
Created Revert of Move throttling of background timers into the renderer scheduler
5 years ago (2015-11-27 10:11:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477353002/1
5 years ago (2015-11-27 10:11:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 10:13:07 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-27 10:14:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f37a89f30c1ccafd36a86369ff2f3b63b251ea1
Cr-Commit-Position: refs/heads/master@{#361972}

Powered by Google App Engine
This is Rietveld 408576698