Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: components/scheduler/renderer/web_frame_scheduler_impl.cc

Issue 1477353002: Revert of Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/web_frame_scheduler_impl.cc
diff --git a/components/scheduler/renderer/web_frame_scheduler_impl.cc b/components/scheduler/renderer/web_frame_scheduler_impl.cc
index b8c1c1a6f176c55b9949e76aaf1d82f89bb1ba06..15e4a7de89b1d0978b2909ce472ad7c1a10a98aa 100644
--- a/components/scheduler/renderer/web_frame_scheduler_impl.cc
+++ b/components/scheduler/renderer/web_frame_scheduler_impl.cc
@@ -4,8 +4,6 @@
#include "components/scheduler/renderer/web_frame_scheduler_impl.h"
-#include "components/scheduler/base/real_time_domain.h"
-#include "components/scheduler/base/virtual_time_domain.h"
#include "components/scheduler/child/web_task_runner_impl.h"
#include "components/scheduler/renderer/renderer_scheduler_impl.h"
#include "components/scheduler/renderer/web_view_scheduler_impl.h"
@@ -18,18 +16,14 @@
WebViewSchedulerImpl* parent_web_view_scheduler)
: renderer_scheduler_(renderer_scheduler),
parent_web_view_scheduler_(parent_web_view_scheduler),
- visible_(true),
- page_in_background_(false) {}
+ visible_(true) {}
WebFrameSchedulerImpl::~WebFrameSchedulerImpl() {
if (loading_task_queue_.get())
loading_task_queue_->UnregisterTaskQueue();
- if (timer_task_queue_.get()) {
- renderer_scheduler_->throttling_helper()->Unthrottle(
- timer_task_queue_.get());
+ if (timer_task_queue_.get())
timer_task_queue_->UnregisterTaskQueue();
- }
if (parent_web_view_scheduler_)
parent_web_view_scheduler_->Unregister(this);
@@ -57,10 +51,6 @@
if (!timer_web_task_runner_) {
timer_task_queue_ =
renderer_scheduler_->NewTimerTaskRunner("frame_timer_tq");
- if (page_in_background_) {
- renderer_scheduler_->throttling_helper()->Throttle(
- timer_task_queue_.get());
- }
timer_web_task_runner_.reset(new WebTaskRunnerImpl(timer_task_queue_));
}
return timer_web_task_runner_.get();
@@ -73,21 +63,4 @@
// TODO(skyostil): Associate the task queues with this origin.
}
-void WebFrameSchedulerImpl::SetPageInBackground(bool page_in_background) {
- if (page_in_background_ == page_in_background)
- return;
-
- page_in_background_ = page_in_background;
-
- if (!timer_web_task_runner_)
- return;
-
- if (page_in_background_) {
- renderer_scheduler_->throttling_helper()->Throttle(timer_task_queue_.get());
- } else {
- renderer_scheduler_->throttling_helper()->Unthrottle(
- timer_task_queue_.get());
- }
-}
-
} // namespace scheduler
« no previous file with comments | « components/scheduler/renderer/web_frame_scheduler_impl.h ('k') | components/scheduler/renderer/web_view_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698