Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: components/scheduler/base/time_domain_unittest.cc

Issue 1477353002: Revert of Move throttling of background timers into the renderer scheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/time_domain.h" 5 #include "components/scheduler/base/time_domain.h"
6 6
7 #include "base/test/simple_test_tick_clock.h" 7 #include "base/test/simple_test_tick_clock.h"
8 #include "cc/test/ordered_simple_task_runner.h" 8 #include "cc/test/ordered_simple_task_runner.h"
9 #include "components/scheduler/base/task_queue_impl.h" 9 #include "components/scheduler/base/task_queue_impl.h"
10 #include "components/scheduler/base/task_queue_manager.h" 10 #include "components/scheduler/base/task_queue_manager.h"
11 #include "components/scheduler/base/task_queue_manager_delegate_for_test.h" 11 #include "components/scheduler/base/task_queue_manager_delegate_for_test.h"
12 #include "components/scheduler/base/test_time_source.h" 12 #include "components/scheduler/base/test_time_source.h"
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 14
15 using testing::_; 15 using testing::_;
16 using testing::Mock; 16 using testing::Mock;
17 17
18 namespace scheduler { 18 namespace scheduler {
19 19
20 class MockTimeDomain : public TimeDomain { 20 class MockTimeDomain : public TimeDomain {
21 public: 21 public:
22 explicit MockTimeDomain(TimeDomain::Observer* observer) 22 MockTimeDomain()
23 : TimeDomain(observer), 23 : now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {}
24 now_(base::TimeTicks() + base::TimeDelta::FromSeconds(1)) {}
25
26 ~MockTimeDomain() override {}
27 24
28 using TimeDomain::NextScheduledRunTime; 25 using TimeDomain::NextScheduledRunTime;
29 using TimeDomain::NextScheduledTaskQueue; 26 using TimeDomain::NextScheduledTaskQueue;
30 using TimeDomain::ScheduleDelayedWork; 27 using TimeDomain::ScheduleDelayedWork;
31 using TimeDomain::UnregisterQueue; 28 using TimeDomain::UnregisterQueue;
32 using TimeDomain::UpdateWorkQueues; 29 using TimeDomain::UpdateWorkQueues;
33 using TimeDomain::RegisterAsUpdatableTaskQueue;
34 30
35 // TimeSource implementation: 31 // TimeSource implementation:
36 LazyNow CreateLazyNow() override { return LazyNow(now_); } 32 LazyNow CreateLazyNow() override { return LazyNow(now_); }
37 33
38 void AsValueIntoInternal( 34 void AsValueIntoInternal(
39 base::trace_event::TracedValue* state) const override {} 35 base::trace_event::TracedValue* state) const override {}
40 36
41 bool MaybeAdvanceTime() override { return false; } 37 bool MaybeAdvanceTime() override { return false; }
42 const char* GetName() const override { return "Test"; } 38 const char* GetName() const override { return "Test"; }
43 void OnRegisterWithTaskQueueManager( 39 void OnRegisterWithTaskQueueManager(
44 TaskQueueManagerDelegate* task_queue_manager_delegate, 40 TaskQueueManagerDelegate* task_queue_manager_delegate,
45 base::Closure do_work_closure) override {} 41 base::Closure do_work_closure) override {}
46 42
47 MOCK_METHOD2(RequestWakeup, void(LazyNow* lazy_now, base::TimeDelta delay)); 43 MOCK_METHOD2(RequestWakeup, void(LazyNow* lazy_now, base::TimeDelta delay));
48 44
49 void SetNow(base::TimeTicks now) { now_ = now; } 45 void SetNow(base::TimeTicks now) { now_ = now; }
50 46
51 base::TimeTicks Now() const { return now_; } 47 base::TimeTicks Now() const { return now_; }
52 48
53 private: 49 private:
54 base::TimeTicks now_; 50 base::TimeTicks now_;
55 51
52 ~MockTimeDomain() override {}
53
56 DISALLOW_COPY_AND_ASSIGN(MockTimeDomain); 54 DISALLOW_COPY_AND_ASSIGN(MockTimeDomain);
57 }; 55 };
58 56
59 class TimeDomainTest : public testing::Test { 57 class TimeDomainTest : public testing::Test {
60 public: 58 public:
61 void SetUp() final { 59 void SetUp() final {
62 time_domain_ = make_scoped_ptr(CreateMockTimeDomain()); 60 time_domain_ = make_scoped_refptr(new MockTimeDomain());
63 task_queue_ = make_scoped_refptr(new internal::TaskQueueImpl( 61 task_queue_ = make_scoped_refptr(new internal::TaskQueueImpl(
64 nullptr, time_domain_.get(), TaskQueue::Spec("test_queue"), 62 nullptr, time_domain_, TaskQueue::Spec("test_queue"), "test.category",
65 "test.category", "test.category")); 63 "test.category"));
66 } 64 }
67 65
68 virtual MockTimeDomain* CreateMockTimeDomain() { 66 scoped_refptr<MockTimeDomain> time_domain_;
69 return new MockTimeDomain(nullptr);
70 }
71
72 scoped_ptr<MockTimeDomain> time_domain_;
73 scoped_refptr<internal::TaskQueueImpl> task_queue_; 67 scoped_refptr<internal::TaskQueueImpl> task_queue_;
74 }; 68 };
75 69
76 TEST_F(TimeDomainTest, ScheduleDelayedWork) { 70 TEST_F(TimeDomainTest, ScheduleDelayedWork) {
77 base::TimeDelta delay = base::TimeDelta::FromMilliseconds(10); 71 base::TimeDelta delay = base::TimeDelta::FromMilliseconds(10);
78 base::TimeTicks delayed_runtime = time_domain_->Now() + delay; 72 base::TimeTicks delayed_runtime = time_domain_->Now() + delay;
79 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay)); 73 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay));
80 LazyNow lazy_now = time_domain_->CreateLazyNow(); 74 LazyNow lazy_now = time_domain_->CreateLazyNow();
81 time_domain_->ScheduleDelayedWork(task_queue_.get(), 75 time_domain_->ScheduleDelayedWork(task_queue_.get(),
82 time_domain_->Now() + delay, &lazy_now); 76 time_domain_->Now() + delay, &lazy_now);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 // RequestWakeup should be called when scheduling earlier tasks. 108 // RequestWakeup should be called when scheduling earlier tasks.
115 Mock::VerifyAndClearExpectations(time_domain_.get()); 109 Mock::VerifyAndClearExpectations(time_domain_.get());
116 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay4)); 110 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay4));
117 time_domain_->ScheduleDelayedWork(task_queue_.get(), 111 time_domain_->ScheduleDelayedWork(task_queue_.get(),
118 time_domain_->Now() + delay4, &lazy_now); 112 time_domain_->Now() + delay4, &lazy_now);
119 } 113 }
120 114
121 TEST_F(TimeDomainTest, UnregisterQueue) { 115 TEST_F(TimeDomainTest, UnregisterQueue) {
122 scoped_refptr<internal::TaskQueueImpl> task_queue2_ = 116 scoped_refptr<internal::TaskQueueImpl> task_queue2_ =
123 make_scoped_refptr(new internal::TaskQueueImpl( 117 make_scoped_refptr(new internal::TaskQueueImpl(
124 nullptr, time_domain_.get(), TaskQueue::Spec("test_queue2"), 118 nullptr, time_domain_, TaskQueue::Spec("test_queue2"),
125 "test.category", "test.category")); 119 "test.category", "test.category"));
126 120
127 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)).Times(1); 121 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)).Times(1);
128 LazyNow lazy_now = time_domain_->CreateLazyNow(); 122 LazyNow lazy_now = time_domain_->CreateLazyNow();
129 time_domain_->ScheduleDelayedWork( 123 time_domain_->ScheduleDelayedWork(
130 task_queue_.get(), 124 task_queue_.get(),
131 time_domain_->Now() + base::TimeDelta::FromMilliseconds(10), &lazy_now); 125 time_domain_->Now() + base::TimeDelta::FromMilliseconds(10), &lazy_now);
132 time_domain_->ScheduleDelayedWork( 126 time_domain_->ScheduleDelayedWork(
133 task_queue2_.get(), 127 task_queue2_.get(),
134 time_domain_->Now() + base::TimeDelta::FromMilliseconds(100), &lazy_now); 128 time_domain_->Now() + base::TimeDelta::FromMilliseconds(100), &lazy_now);
135 129
136 TaskQueue* next_task_queue; 130 TaskQueue* next_task_queue;
137 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 131 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
138 EXPECT_EQ(task_queue_.get(), next_task_queue); 132 EXPECT_EQ(task_queue_.get(), next_task_queue);
139 133
140 time_domain_->UnregisterQueue(task_queue_.get()); 134 time_domain_->UnregisterQueue(task_queue_.get());
141 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 135 EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
142 EXPECT_EQ(task_queue2_.get(), next_task_queue); 136 EXPECT_EQ(task_queue2_.get(), next_task_queue);
143 137
144 time_domain_->UnregisterQueue(task_queue2_.get()); 138 time_domain_->UnregisterQueue(task_queue2_.get());
145 EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue)); 139 EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
146 } 140 }
147 141
148 TEST_F(TimeDomainTest, UpdateWorkQueues) { 142 TEST_F(TimeDomainTest, UpdateWorkQueues) {
149 scoped_ptr<MockTimeDomain> dummy_delegate(new MockTimeDomain(nullptr)); 143 scoped_refptr<MockTimeDomain> dummy_delegate(new MockTimeDomain());
150 base::SimpleTestTickClock dummy_time_source; 144 base::SimpleTestTickClock dummy_time_source;
151 scoped_refptr<cc::OrderedSimpleTaskRunner> dummy_task_runner( 145 scoped_refptr<cc::OrderedSimpleTaskRunner> dummy_task_runner(
152 new cc::OrderedSimpleTaskRunner(&dummy_time_source, false)); 146 new cc::OrderedSimpleTaskRunner(&dummy_time_source, false));
153 TaskQueueManager task_queue_manager( 147 TaskQueueManager task_queue_manager(
154 TaskQueueManagerDelegateForTest::Create( 148 TaskQueueManagerDelegateForTest::Create(
155 dummy_task_runner, 149 dummy_task_runner,
156 make_scoped_ptr(new TestTimeSource(&dummy_time_source))), 150 make_scoped_ptr(new TestTimeSource(&dummy_time_source))),
157 "test.scheduler", "test.scheduler", "scheduler.debug"); 151 "test.scheduler", "test.scheduler", "scheduler.debug");
158 scoped_refptr<internal::TaskQueueImpl> dummy_queue = 152 scoped_refptr<internal::TaskQueueImpl> dummy_queue =
159 task_queue_manager.NewTaskQueue(TaskQueue::Spec("test_queue")); 153 task_queue_manager.NewTaskQueue(TaskQueue::Spec("test_queue"));
(...skipping 15 matching lines...) Expand all
175 &lazy_now); 169 &lazy_now);
176 170
177 time_domain_->UpdateWorkQueues(false, nullptr); 171 time_domain_->UpdateWorkQueues(false, nullptr);
178 EXPECT_EQ(0UL, dummy_queue->IncomingQueueSizeForTest()); 172 EXPECT_EQ(0UL, dummy_queue->IncomingQueueSizeForTest());
179 173
180 time_domain_->SetNow(delayed_runtime); 174 time_domain_->SetNow(delayed_runtime);
181 time_domain_->UpdateWorkQueues(false, nullptr); 175 time_domain_->UpdateWorkQueues(false, nullptr);
182 EXPECT_EQ(1UL, dummy_queue->IncomingQueueSizeForTest()); 176 EXPECT_EQ(1UL, dummy_queue->IncomingQueueSizeForTest());
183 } 177 }
184 178
185 namespace {
186 class MockObserver : public TimeDomain::Observer {
187 public:
188 ~MockObserver() override {}
189
190 MOCK_METHOD0(OnTimeDomainHasImmediateWork, void());
191 MOCK_METHOD0(OnTimeDomainHasDelayedWork, void());
192 };
193 } // namespace
194
195 class TimeDomainWithObserverTest : public TimeDomainTest {
196 public:
197 MockTimeDomain* CreateMockTimeDomain() override {
198 observer_.reset(new MockObserver());
199 return new MockTimeDomain(observer_.get());
200 }
201
202 scoped_ptr<MockObserver> observer_;
203 };
204
205 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {
206 EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork());
207 time_domain_->RegisterAsUpdatableTaskQueue(task_queue_.get());
208 }
209
210 TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {
211 EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork());
212 EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _));
213 LazyNow lazy_now = time_domain_->CreateLazyNow();
214 time_domain_->ScheduleDelayedWork(
215 task_queue_.get(),
216 time_domain_->Now() + base::TimeDelta::FromMilliseconds(10), &lazy_now);
217 }
218
219 } // namespace scheduler 179 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/base/time_domain.cc ('k') | components/scheduler/base/virtual_time_domain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698