Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 14772019: Added game-like bench marks (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
bsalomon, reed1
CC:
reed1
Visibility:
Public.

Description

Need these to diagnose Chrome-side performance regressions. The overall lesson is 565 needs a new blitter. game_rot_partial_aa 8888: cmsecs = 396.24 565: cmsecs = 524.16 GPU: cmsecs = 37.44 game_trans_partial_aa 8888: cmsecs = 60.84 565: cmsecs = 190.32 GPU: cmsecs = 40.56 game_scale_partial_aa 8888: cmsecs = 310.44 565: cmsecs = 458.64 GPU: cmsecs = 43.68 game_rot_full_aa 8888: cmsecs = 280.80 565: cmsecs = 411.84 GPU: cmsecs = 21.84 game_trans_full_aa 8888: cmsecs = 39.00 565: cmsecs = 168.48 GPU: cmsecs = 20.28 game_scale_full_aa 8888: cmsecs = 274.56 565: cmsecs = 432.12 GPU: cmsecs = 21.84

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed code review issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -0 lines) Patch
A bench/GameBench.cpp View 1 1 chunk +206 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-09 15:42:57 UTC) #1
bsalomon
lgtm w/ some questions https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp File bench/GameBench.cpp (right): https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp#newcode15 bench/GameBench.cpp:15: // This bench simulates the ...
7 years, 7 months ago (2013-05-09 15:50:46 UTC) #2
reed1
https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp File bench/GameBench.cpp (right): https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp#newcode58 bench/GameBench.cpp:58: this->makeCheckerboard(); can we do this lazily, so the constructor ...
7 years, 7 months ago (2013-05-09 16:04:55 UTC) #3
robertphillips
PTAL https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp File bench/GameBench.cpp (right): https://codereview.chromium.org/14772019/diff/1/bench/GameBench.cpp#newcode19 bench/GameBench.cpp:19: static const unsigned int kNumRects = 5000; On ...
7 years, 7 months ago (2013-05-09 18:49:15 UTC) #4
bsalomon
lgtm
7 years, 7 months ago (2013-05-09 18:51:46 UTC) #5
robertphillips
7 years, 7 months ago (2013-05-09 19:04:05 UTC) #6
Message was sent while issue was closed.
committed as r9078

Powered by Google App Engine
This is Rietveld 408576698