Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1476233003: ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h (Closed)

Created:
5 years ago by r.kasibhatla
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@sysroot_off_clang_off
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true Committed: https://crrev.com/3e87aec5b47e8c52847379d9a775b2e12da27550 Cr-Commit-Position: refs/heads/master@{#362674}

Patch Set 1 #

Patch Set 2 : Removed the dependency of the local patch! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ppapi/lib/gl/include/GLES2/gl2ext.h View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (14 generated)
RaviKasibhatla
PTAL!
5 years ago (2015-11-26 12:29:07 UTC) #4
RaviKasibhatla
On 2015/11/26 12:29:07, RaviKasibhatla wrote: > PTAL! Gentle remainder! :)
5 years ago (2015-11-30 10:37:46 UTC) #5
piman
lgtm
5 years ago (2015-11-30 21:47:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
5 years ago (2015-12-01 04:56:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123425)
5 years ago (2015-12-01 05:08:04 UTC) #10
RaviKasibhatla
+ bbudge and raymes for OWNER lgtm
5 years ago (2015-12-01 05:53:42 UTC) #12
raymes
rubberstamp lgtm
5 years ago (2015-12-01 05:54:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
5 years ago (2015-12-01 06:17:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123437)
5 years ago (2015-12-01 06:25:09 UTC) #17
RaviKasibhatla
On 2015/12/01 06:25:09, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-01 06:28:59 UTC) #18
RaviKasibhatla
On 2015/12/01 06:28:59, RaviKasibhatla wrote: > On 2015/12/01 06:25:09, commit-bot: I haz the power wrote: ...
5 years ago (2015-12-02 09:18:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
5 years ago (2015-12-02 09:19:21 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123983)
5 years ago (2015-12-02 09:27:43 UTC) #23
RaviKasibhatla
On 2015/12/02 09:27:43, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years ago (2015-12-02 10:05:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
5 years ago (2015-12-02 10:07:22 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 10:08:29 UTC) #29
commit-bot: I haz the power
5 years ago (2015-12-02 10:09:11 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e87aec5b47e8c52847379d9a775b2e12da27550
Cr-Commit-Position: refs/heads/master@{#362674}

Powered by Google App Engine
This is Rietveld 408576698