|
|
Created:
5 years ago by r.kasibhatla Modified:
5 years ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@sysroot_off_clang_off Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h
The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT
and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos
updated header third_party/khronos/GLES2/gl2ext.h should be
0x8CAB, 0x8D57 and 0x8D56 respectively.
The values of 0x9133, 0x9134 and 0x9135 instead point to
GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and
GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG.
BUG=None
NOPRESUBMIT=true
Committed: https://crrev.com/3e87aec5b47e8c52847379d9a775b2e12da27550
Cr-Commit-Position: refs/heads/master@{#362674}
Patch Set 1 #Patch Set 2 : Removed the dependency of the local patch! #
Depends on Patchset: Messages
Total messages: 31 (14 generated)
Description was changed from ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None ========== to ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None ==========
kphanee@chromium.org changed reviewers: + piman@chromium.org, vmiura@chromium.org
kphanee@chromium.org changed reviewers: + kphanee@chromium.org
PTAL!
On 2015/11/26 12:29:07, RaviKasibhatla wrote: > PTAL! Gentle remainder! :)
lgtm
The CQ bit was checked by kphanee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kphanee@chromium.org changed reviewers: + bbudge@chromium.org, raymes@chromium.org
+ bbudge and raymes for OWNER lgtm
rubberstamp lgtm
The CQ bit was checked by kphanee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2015/12/01 06:25:09, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) @raymes: Presubmit is complaining about missing BSD licence. Do I change the license on this file to BSD? ** Presubmit Warnings ** License must match: .*? Copyright (\(c\) )?(2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010) The Chromium Authors\. All rights reserved\.\n.*? Use of this source code is governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?: \*/)?\n Found a bad license header in these files: ppapi/lib/gl/include/GLES2/gl2ext.h
On 2015/12/01 06:28:59, RaviKasibhatla wrote: > On 2015/12/01 06:25:09, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > @raymes: Presubmit is complaining about missing BSD licence. Do I change the > license on this file to BSD? > > ** Presubmit Warnings ** > License must match: > .*? Copyright (\(c\) > )?(2015|2014|2013|2012|2011|2010|2009|2008|2007|2006|2006-2008|2006-2009|2006-2010) > The Chromium Authors\. All rights reserved\.\n.*? Use of this source code is > governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?: > \*/)?\n > Found a bad license header in these files: > ppapi/lib/gl/include/GLES2/gl2ext.h @raymes/@piman: How to get over the license presubmit error? Ideas?
The CQ bit was checked by kphanee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2015/12/02 09:27:43, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Referring to the patches https://codereview.chromium.org/1341423006 and https://codereview.chromium.org/1203793003, I noticed that we marked the patches as NOPRESUBMIT=true. I believe the same procedure will work for this patch as well. Trying the same.
Description was changed from ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None ========== to ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true ==========
The CQ bit was checked by kphanee@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476233003/20001
Message was sent while issue was closed.
Description was changed from ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true ========== to ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true ========== to ========== ppapi: make gl2ext.h values consistent with third_party/khronos/GLES2/gl2ext.h The values of GL_RENDERBUFFER_SAMPLES_EXT, GL_MAX_SAMPLES_EXT and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT as per khronos updated header third_party/khronos/GLES2/gl2ext.h should be 0x8CAB, 0x8D57 and 0x8D56 respectively. The values of 0x9133, 0x9134 and 0x9135 instead point to GL_RENDERBUFFER_SAMPLES_IMG, GL_MAX_SAMPLES_IMG and GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_IMG. BUG=None NOPRESUBMIT=true Committed: https://crrev.com/3e87aec5b47e8c52847379d9a775b2e12da27550 Cr-Commit-Position: refs/heads/master@{#362674} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3e87aec5b47e8c52847379d9a775b2e12da27550 Cr-Commit-Position: refs/heads/master@{#362674} |