Removing GL context rate limiting feature and related wrappers

Removing GL context rate limiting feature and related wrappers

Dead code removal.

BUG=531659
TBR=jamesr@chromium.org, vmiura@chromium.org
NOPRESUBMIT=true

Committed: https://crrev.com/e4787c4cc75862dbe9eaf4610284544828c33745
Cr-Commit-Position: refs/heads/master@{#350172}

[Justin Novosad, 2015-09-21 15:26:35]

junov@chromium.org changed reviewers:
+ bbudge@chromium.org, enne@chromium.org, sievers@chromium.org,
sky@chromium.org, vmiura@chromium.org

[Justin Novosad, 2015-09-21 15:26:36]

PTAL

enne: /cc + content/renderer/gpu
sievers: /gpu
bbudge: /ppapi
sky: components/html_viewer/
vmiura: mojo/gpu/


Note: This must land first: https://codereview.chromium.org/1352653002/

[no sievers, 2015-09-21 19:32:21]

lgtm

[enne (OOO), 2015-09-21 19:46:55]

cc lgtm

[enne (OOO), 2015-09-21 19:47:17]

On 2015/09/21 at 19:46:55, enne wrote:
> cc lgtm

...and content/renderer/gpu too, I mean.

[danakj, 2015-09-21 19:48:32]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-09-21 19:48:33]

driveby couple more removals?

https://codereview.chromium.org/1341423006/diff/1/cc/trees/layer_tree_host.cc
File cc/trees/layer_tree_host.cc (right):

https://codereview.chromium.org/1341423006/diff/1/cc/trees/layer_tree_host.cc...
cc/trees/layer_tree_host.cc:226: inside_begin_main_frame_ = true;
this var is no longer used, can go?

https://codereview.chromium.org/1341423006/diff/1/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/1341423006/diff/1/cc/trees/layer_tree_host.h#...
cc/trees/layer_tree_host.h:451: base::OneShotTimer<LayerTreeHost>
rate_limit_timer_;
can go too?

https://codereview.chromium.org/1341423006/diff/1/cc/trees/thread_proxy.cc
File cc/trees/thread_proxy.cc (left):

https://codereview.chromium.org/1341423006/diff/1/cc/trees/thread_proxy.cc#ol...
cc/trees/thread_proxy.cc:625: impl().layer_tree_host_impl->renderer()->DoNoOp();
https://code.google.com/p/chromium/codesearch#chromium/src/cc/output/renderer...
this DoNoOp can go too?

[Justin Novosad, 2015-09-21 19:49:58]

On 2015/09/21 19:47:17, enne wrote:
> On 2015/09/21 at 19:46:55, enne wrote:
> > cc lgtm
> 
> ...and content/renderer/gpu too, I mean.

Thanks, the missing l-g-t-m areas rather tiny rubber stamp-ish things, so I'll
TBR the rest of the reviewers.

[bbudge, 2015-09-21 19:58:57]

ppapi lgtm

[Justin Novosad, 2015-09-21 20:45:55]

Did additional deletions suggested by Eagle Eye Dana, and rebased.

[Justin Novosad, 2015-09-21 20:46:06]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-09-21 20:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
enne@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1341423006/#ps20001
(title: "more deletions")

[commit-bot: I haz the power, 2015-09-21 20:47:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423006/20001

[danakj, 2015-09-21 20:49:05]

Yay LGTM

[danakj, 2015-09-21 20:49:25]

https://codereview.chromium.org/1341423006/diff/20001/cc/trees/layer_tree_host.h
File cc/trees/layer_tree_host.h (right):

https://codereview.chromium.org/1341423006/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host.h:20: #include "base/timer/timer.h"
oh.not needed now?

[Justin Novosad, 2015-09-21 20:53:02]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2015-09-21 20:53:16]

On 2015/09/21 20:49:25, danakj wrote:
>
https://codereview.chromium.org/1341423006/diff/20001/cc/trees/layer_tree_host.h
> File cc/trees/layer_tree_host.h (right):
> 
>
https://codereview.chromium.org/1341423006/diff/20001/cc/trees/layer_tree_hos...
> cc/trees/layer_tree_host.h:20: #include "base/timer/timer.h"
> oh.not needed now?

Good catch.  BRB

[Justin Novosad, 2015-09-21 20:55:53]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-09-21 20:55:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
enne@chromium.org, danakj@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1341423006/#ps40001
(title: "remove unnecessary include")

[commit-bot: I haz the power, 2015-09-21 20:57:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423006/40001

[commit-bot: I haz the power, 2015-09-21 21:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 21:13:59]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sky, 2015-09-21 23:31:01]

html_viewer LGTM

[Justin Novosad, 2015-09-22 14:13:14]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-09-22 14:13:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
sky@chromium.org, enne@chromium.org, danakj@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1341423006/#ps60001
(title: "removing unneeded unit test")

[commit-bot: I haz the power, 2015-09-22 14:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423006/60001

[commit-bot: I haz the power, 2015-09-22 14:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 14:27:30]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Justin Novosad, 2015-09-22 15:05:05]

Reviewers: I am getting build error in mojo stuff. Any of you know what script I
need to run to update the mojo autogen source files? Ex:
third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h

[Justin Novosad, 2015-09-22 15:23:40]

On 2015/09/22 15:05:05, Justin Novosad wrote:
> Reviewers: I am getting build error in mojo stuff. Any of you know what script
I
> need to run to update the mojo autogen source files? Ex:
>
third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_extension_autogen.h

Nevermind, it was a clash with a recent CL. I had not re-run
gpu/command_buffer/build_gles2_cmd_buffer.py since my last rebase

[Justin Novosad, 2015-09-22 15:30:34]

The CQ bit was checked by junov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 15:31:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423006/80001

[Justin Novosad, 2015-09-22 15:36:10]

The CQ bit was unchecked by junov@chromium.org

[Justin Novosad, 2015-09-22 15:36:22]

The CQ bit was checked by junov@chromium.org

[Justin Novosad, 2015-09-22 15:36:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
sky@chromium.org, enne@chromium.org, danakj@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1341423006/#ps80001
(title: "fixed mojo autogens")

[commit-bot: I haz the power, 2015-09-22 15:36:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1341423006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1341423006/80001

[commit-bot: I haz the power, 2015-09-22 16:47:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-22 16:48:04]

Patchset 5 (id:??) landed as
https://crrev.com/e4787c4cc75862dbe9eaf4610284544828c33745
Cr-Commit-Position: refs/heads/master@{#350172}