Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1473513008: Disable sysroot option when clang build is disabled (Closed)

Created:
5 years ago by r.kasibhatla
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable sysroot option when clang build is disabled Current sysroot image supports gcc <= 4.6. When clang build is disabled and gcc > 4.6, builds fails as gcc doesn't find the system headers in sysroot location. So disabling sysroot option when clang is disabled. Ref: https://code.google.com/p/chromium/issues/detail?id=504446#c17 Disabling the sysroot option as per discussion below: https://groups.google.com/a/chromium.org/d/msg/chromium-dev/8BILwhBeVCw/TEjLtO2fAAAJ BUG=504446 TESTS=NONE R=dpranke,sbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M build/common.gypi View 7 chunks +23 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
RaviKasibhatla
PTAL! When adding the condition in the same conditions block where we are setting sysroot% ...
5 years ago (2015-11-26 11:05:34 UTC) #2
RaviKasibhatla
5 years ago (2015-11-26 11:06:10 UTC) #4
Sam Clegg
On 2015/11/26 11:06:10, RaviKasibhatla wrote: Ooop, I already have an equivalent CL: https://codereview.chromium.org/1476923005/. I should ...
5 years ago (2015-11-26 16:36:13 UTC) #5
r.kasibhatla
5 years ago (2015-11-26 17:31:46 UTC) #6
On 2015/11/26 at 16:36:13, sbc wrote:
> On 2015/11/26 11:06:10, RaviKasibhatla wrote:
> 
> Ooop,  I already have an equivalent CL:
https://codereview.chromium.org/1476923005/.  I should have CC'd you.

No problem. Thanks for the quick patch. :)

Powered by Google App Engine
This is Rietveld 408576698