Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2406)

Unified Diff: cc/base/tiling_data_unittest.cc

Issue 147603006: [#7] Resubmitted - Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resubmit 145313006 Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/base/tiling_data.cc ('k') | cc/layers/delegated_renderer_layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/base/tiling_data_unittest.cc
diff --git a/cc/base/tiling_data_unittest.cc b/cc/base/tiling_data_unittest.cc
index db2d6f215a9a86e2d370fe963f2b3a8502d30236..55b3b6d77ecf7637fdc8012aa1e1c6fdc3d6b7c3 100644
--- a/cc/base/tiling_data_unittest.cc
+++ b/cc/base/tiling_data_unittest.cc
@@ -13,8 +13,8 @@ namespace cc {
namespace {
int NumTiles(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
int num_tiles = tiling.num_tiles_x() * tiling.num_tiles_y();
@@ -28,8 +28,8 @@ int NumTiles(
}
int XIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int x_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -37,8 +37,8 @@ int XIndex(
}
int YIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int y_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -46,8 +46,8 @@ int YIndex(
}
int MinBorderXIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int x_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -55,8 +55,8 @@ int MinBorderXIndex(
}
int MinBorderYIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int y_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -64,8 +64,8 @@ int MinBorderYIndex(
}
int MaxBorderXIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int x_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -73,8 +73,8 @@ int MaxBorderXIndex(
}
int MaxBorderYIndex(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int y_coord) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -82,8 +82,8 @@ int MaxBorderYIndex(
}
int PosX(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int x_index) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -91,8 +91,8 @@ int PosX(
}
int PosY(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int y_index) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -100,8 +100,8 @@ int PosY(
}
int SizeX(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int x_index) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
@@ -109,8 +109,8 @@ int SizeX(
}
int SizeY(
- gfx::Size max_texture_size,
- gfx::Size total_size,
+ const gfx::Size& max_texture_size,
+ const gfx::Size& total_size,
bool has_border_texels,
int y_index) {
TilingData tiling(max_texture_size, total_size, has_border_texels);
« no previous file with comments | « cc/base/tiling_data.cc ('k') | cc/layers/delegated_renderer_layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698