cc/base/math_util.cc - Issue 147603006: [#7] Resubmitted - Pass gfx structs by const ref (gfx::Size)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/base/math_util.cc

Issue 147603006: [#7] Resubmitted - Pass gfx structs by const ref (gfx::Size) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resubmit 145313006 Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/base/math_util.cc

diff --git a/cc/base/math_util.cc b/cc/base/math_util.cc

index 8abfa90f0b31ca301824859546258fbb8f9074fd..72b1e7f17728e4d0f9fc8784b96663728c9bf7c6 100644

--- a/cc/base/math_util.cc

+++ b/cc/base/math_util.cc

@@ -508,7 +508,7 @@ gfx::Vector2dF MathUtil::ProjectVector(const gfx::Vector2dF& source,

projected_length * destination.y());

}

-scoped_ptr<base::Value> MathUtil::AsValue(gfx::Size s) {

+scoped_ptr<base::Value> MathUtil::AsValue(const gfx::Size& s) {

scoped_ptr<base::DictionaryValue> res(new base::DictionaryValue());

res->SetDouble("width", s.width());

res->SetDouble("height", s.height());

« no previous file with comments | « cc/base/math_util.h ('k') | cc/base/tiling_data.h » ('j') | no next file with comments »