Always pass an Isolate to AssemblerBase

Always pass an Isolate to AssemblerBase

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org
LOG=n

Committed: https://crrev.com/e03cadab09ba65c18175afcf79c363fdaa157b31
Cr-Commit-Position: refs/heads/master@{#32359}

[jochen (gone - plz use gerrit), 2015-11-26 16:03:06]

ptal

[jochen (gone - plz use gerrit), 2015-11-26 16:04:43]

apart from deleting some unused code, it's pretty mechanical: CodePatcher (aka
PatchingAssembler, you little snowflake, arm64) gets an isolate ctor parameter,
and we pass it all over the place.

Also replace FlushICacheWithoutIsolate with FlushICache where possible

[Michael Starzinger, 2015-11-26 17:41:46]

LGTM.

https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc#newcod...
src/assembler.cc:176: DCHECK(isolate);
nit: DCHECK_NOT_NULL

[jochen (gone - plz use gerrit), 2015-11-27 07:55:35]

https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc#newcod...
src/assembler.cc:176: DCHECK(isolate);
On 2015/11/26 at 17:41:46, Michael Starzinger wrote:
> nit: DCHECK_NOT_NULL

done

[jochen (gone - plz use gerrit), 2015-11-27 07:56:27]

Yang, can you look at debug/ please
Jakob, can you look at ic/ please

[Yang, 2015-11-27 08:02:37]

On 2015/11/26 17:41:46, Michael Starzinger wrote:
> LGTM.
> 
> https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc
> File src/assembler.cc (right):
> 
>
https://codereview.chromium.org/1474763008/diff/20001/src/assembler.cc#newcod...
> src/assembler.cc:176: DCHECK(isolate);
> nit: DCHECK_NOT_NULL

src/debug and src/full-codegen lgtm.

[Jakob Kummerow, 2015-11-27 08:27:14]

src/ic/* LGTM.

[jochen (gone - plz use gerrit), 2015-11-27 08:29:19]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-27 08:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1474763008/#ps40001
(title: "updates")

[commit-bot: I haz the power, 2015-11-27 08:29:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1474763008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1474763008/40001

[commit-bot: I haz the power, 2015-11-27 08:37:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-27 08:37:56]

Description was changed from

==========
Always pass an Isolate to AssemblerBase

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org
LOG=n
==========

to

==========
Always pass an Isolate to AssemblerBase

BUG=v8:2487
R=yangguo@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org
LOG=n

Committed: https://crrev.com/e03cadab09ba65c18175afcf79c363fdaa157b31
Cr-Commit-Position: refs/heads/master@{#32359}
==========

[commit-bot: I haz the power, 2015-11-27 08:37:57]

Patchset 3 (id:??) landed as
https://crrev.com/e03cadab09ba65c18175afcf79c363fdaa157b31
Cr-Commit-Position: refs/heads/master@{#32359}