Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: src/arm/assembler-arm.cc

Issue 1474763008: Always pass an Isolate to AssemblerBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm/codegen-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index c572b747df6cf408169b7c432fdfca22945c2314..2dbbea3814ad480f3d40652054d60f4eb74b10c7 100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -843,8 +843,7 @@ void Assembler::target_at_put(int pos, int target_pos) {
if (is_uint8(target24)) {
// If the target fits in a byte then only patch with a mov
// instruction.
- CodePatcher patcher(reinterpret_cast<byte*>(buffer_ + pos),
- 1,
+ CodePatcher patcher(isolate(), reinterpret_cast<byte*>(buffer_ + pos), 1,
CodePatcher::DONT_FLUSH);
patcher.masm()->mov(dst, Operand(target24));
} else {
@@ -853,14 +852,12 @@ void Assembler::target_at_put(int pos, int target_pos) {
if (CpuFeatures::IsSupported(ARMv7)) {
// Patch with movw/movt.
if (target16_1 == 0) {
- CodePatcher patcher(reinterpret_cast<byte*>(buffer_ + pos),
- 1,
- CodePatcher::DONT_FLUSH);
+ CodePatcher patcher(isolate(), reinterpret_cast<byte*>(buffer_ + pos),
+ 1, CodePatcher::DONT_FLUSH);
patcher.masm()->movw(dst, target16_0);
} else {
- CodePatcher patcher(reinterpret_cast<byte*>(buffer_ + pos),
- 2,
- CodePatcher::DONT_FLUSH);
+ CodePatcher patcher(isolate(), reinterpret_cast<byte*>(buffer_ + pos),
+ 2, CodePatcher::DONT_FLUSH);
patcher.masm()->movw(dst, target16_0);
patcher.masm()->movt(dst, target16_1);
}
@@ -870,15 +867,13 @@ void Assembler::target_at_put(int pos, int target_pos) {
uint8_t target8_1 = target16_0 >> 8;
uint8_t target8_2 = target16_1 & kImm8Mask;
if (target8_2 == 0) {
- CodePatcher patcher(reinterpret_cast<byte*>(buffer_ + pos),
- 2,
- CodePatcher::DONT_FLUSH);
+ CodePatcher patcher(isolate(), reinterpret_cast<byte*>(buffer_ + pos),
+ 2, CodePatcher::DONT_FLUSH);
patcher.masm()->mov(dst, Operand(target8_0));
patcher.masm()->orr(dst, dst, Operand(target8_1 << 8));
} else {
- CodePatcher patcher(reinterpret_cast<byte*>(buffer_ + pos),
- 3,
- CodePatcher::DONT_FLUSH);
+ CodePatcher patcher(isolate(), reinterpret_cast<byte*>(buffer_ + pos),
+ 3, CodePatcher::DONT_FLUSH);
patcher.masm()->mov(dst, Operand(target8_0));
patcher.masm()->orr(dst, dst, Operand(target8_1 << 8));
patcher.masm()->orr(dst, dst, Operand(target8_2 << 16));
« no previous file with comments | « no previous file | src/arm/codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698