src/x87/assembler-x87-inl.h - Issue 1474763008: Always pass an Isolate to AssemblerBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/assembler-x87-inl.h

Issue 1474763008: Always pass an Isolate to AssemblerBase (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x87/assembler-x87-inl.h

diff --git a/src/x87/assembler-x87-inl.h b/src/x87/assembler-x87-inl.h

index ef8876c15a907109fdb8e616a2a503f98199d071..7532e687983694e72b7afb84950312fe96e41bd4 100644

--- a/src/x87/assembler-x87-inl.h

+++ b/src/x87/assembler-x87-inl.h

@@ -281,7 +281,7 @@ void RelocInfo::Visit(Isolate* isolate, ObjectVisitor* visitor) {

RelocInfo::Mode mode = rmode();

if (mode == RelocInfo::EMBEDDED_OBJECT) {

visitor->VisitEmbeddedPointer(this);

- Assembler::FlushICacheWithoutIsolate(pc_, sizeof(Address));

+ Assembler::FlushICache(isolate, pc_, sizeof(Address));

} else if (RelocInfo::IsCodeTarget(mode)) {

visitor->VisitCodeTarget(this);

} else if (mode == RelocInfo::CELL) {

@@ -306,7 +306,7 @@ void RelocInfo::Visit(Heap* heap) {

RelocInfo::Mode mode = rmode();

if (mode == RelocInfo::EMBEDDED_OBJECT) {

StaticVisitor::VisitEmbeddedPointer(heap, this);

- Assembler::FlushICacheWithoutIsolate(pc_, sizeof(Address));

+ Assembler::FlushICache(heap->isolate(), pc_, sizeof(Address));

} else if (RelocInfo::IsCodeTarget(mode)) {

StaticVisitor::VisitCodeTarget(heap, this);

} else if (mode == RelocInfo::CELL) {

« no previous file with comments | « src/x87/assembler-x87.cc ('k') | src/x87/codegen-x87.cc » ('j') | no next file with comments »