chrome/browser/ui/sync/one_click_signin_sync_starter.h - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/startup_browser_creator_impl.cc ('K') | « chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.cc » ('j') | chrome/browser/ui/views/profiles/profile_chooser_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_sync_starter.h

diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.h b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

index 0e4c815059e0e5046a3b93e7321e590c8975328b..5309daa8313f72b832444d290ca11aeca299cdc3 100644

--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.h

+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.h

@@ -101,6 +101,7 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

StartSyncMode start_mode,

content::WebContents* web_contents,

ConfirmationRequired display_confirmation,

+ const GURL& current_url,

const GURL& continue_url,

Callback callback);

@@ -225,6 +226,7 @@ class OneClickSigninSyncStarter : public SigninTracker::Observer,

StartSyncMode start_mode_;

chrome::HostDesktopType desktop_type_;

ConfirmationRequired confirmation_required_;

+ GURL current_url_;

GURL continue_url_;

// Callback executed when sync setup succeeds or fails.