chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/chrome_pages.cc ('K') | « chrome/browser/ui/startup/startup_browser_creator_browsertest.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc » ('j') | chrome/browser/ui/views/profiles/profile_chooser_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 95cae74a73ecbb497b38a7dc9280880141f7c560..d2b9edd2c727b48df4287979f6513c336201dfb7 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -872,7 +872,8 @@ void StartupBrowserCreatorImpl::AddStartupURLs(

signin::DidShowPromoAtStartup(profile_);

const GURL sync_promo_url = signin::GetPromoURL(

- signin_metrics::SOURCE_START_PAGE, false);

+ signin_metrics::ACCESS_POINT_START_PAGE,

+ signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT, false);

sky 2015/12/03 22:45:28 What is meant by PRIMARY and SECONDARY accounts? S

gogerald1 2015/12/04 20:49:09 PRIMARY means sign in an account as primary accoun

// No need to add if the sync promo is already in the startup list.

bool add_promo = true;