Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view.h

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view.h
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.h b/chrome/browser/ui/views/profiles/profile_chooser_view.h
index 923989ed372ad8e5d62e0457ace6d4792ac0b165..2f92385adf32cde43ea981e246c501361c3de89c 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.h
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.h
@@ -58,6 +58,7 @@ class ProfileChooserView : public content::WebContentsDelegate,
profiles::BubbleViewMode view_mode,
profiles::TutorialMode tutorial_mode,
const signin::ManageAccountsParams& manage_accounts_params,
+ signin_metrics::AccessPoint access_point,
views::View* anchor_view,
views::BubbleBorder::Arrow arrow,
views::BubbleBorder::BubbleAlignment border_alignment,
@@ -77,7 +78,8 @@ class ProfileChooserView : public content::WebContentsDelegate,
Browser* browser,
profiles::BubbleViewMode view_mode,
profiles::TutorialMode tutorial_mode,
- signin::GAIAServiceType service_type);
+ signin::GAIAServiceType service_type,
+ signin_metrics::AccessPoint access_point);
~ProfileChooserView() override;
// views::BubbleDelegateView:
@@ -272,6 +274,9 @@ class ProfileChooserView : public content::WebContentsDelegate,
// The GAIA service type provided in the response header.
signin::GAIAServiceType gaia_service_type_;
+ // The current access point of sign in.
+ signin_metrics::AccessPoint access_point_;
sky 2015/12/03 22:45:28 const
gogerald1 2015/12/04 20:49:09 Done.
+
DISALLOW_COPY_AND_ASSIGN(ProfileChooserView);
};

Powered by Google App Engine
This is Rietveld 408576698