Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc

Issue 1473543002: Implement newly designed sign-in related histograms for desktop platorms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
index e1a0c3205d6547d23e46d53b5f7c1f74992a763b..c483ffbe21939b75d8dee7baf02e73aebcf17032 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc
@@ -235,8 +235,9 @@ TEST_F(OneClickSigninSyncObserverTest,
// triggered, since it would be redundant.
TEST_F(OneClickSigninSyncObserverTest,
OnSyncStateChanged_SyncConfiguredSuccessfully_SourceIsSettings) {
- GURL continue_url = signin::GetPromoURL(
- signin_metrics::SOURCE_SETTINGS, false);
+ GURL continue_url =
+ signin::GetPromoURL(signin_metrics::ACCESS_POINT_SETTINGS,
+ signin_metrics::REASON_SIGNIN_PRIMARY_ACCOUNT, false);
CreateSyncObserver(continue_url.spec());
sync_service_->set_first_setup_in_progress(false);
sync_service_->set_sync_active(true);

Powered by Google App Engine
This is Rietveld 408576698