Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: breakpad/breakpad.gyp

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added bug reference in comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/breakpad.gyp
diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp
index 52bf0db1e877d9f35c64a98e3568624ae25853d7..00d2bc547c2ad5a6e35b86d23bb5245f7617f20b 100644
--- a/breakpad/breakpad.gyp
+++ b/breakpad/breakpad.gyp
@@ -595,6 +595,14 @@
],
},
}],
+ ['clang==1 and target_arch=="ia32"', {
+ 'cflags!': [
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ '-mstackrealign',
+ ],
+ }],
],
'include_dirs': [
@@ -704,6 +712,14 @@
},
'includes': [ '../build/android/test_runner.gypi' ],
}],
+ ['clang==1 and target_arch=="ia32"', {
+ 'cflags!': [
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ '-mstackrealign',
+ ],
+ }],
],
},
{
« no previous file with comments | « breakpad/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698