Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Side by Side Diff: breakpad/breakpad.gyp

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added bug reference in comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « breakpad/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'breakpad_sender.gypi', 7 'breakpad_sender.gypi',
8 'breakpad_handler.gypi', 8 'breakpad_handler.gypi',
9 ], 9 ],
10 'conditions': [ 10 'conditions': [
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 ['OS!="android"', { 588 ['OS!="android"', {
589 'link_settings': { 589 'link_settings': {
590 'libraries': [ 590 'libraries': [
591 # In case of Android, '-ldl' is added in common.gypi, since it 591 # In case of Android, '-ldl' is added in common.gypi, since it
592 # is needed for stlport_static. For LD, the order of libraries 592 # is needed for stlport_static. For LD, the order of libraries
593 # is important, and thus we skip to add it here. 593 # is important, and thus we skip to add it here.
594 '-ldl', 594 '-ldl',
595 ], 595 ],
596 }, 596 },
597 }], 597 }],
598 ['clang==1 and target_arch=="ia32"', {
599 'cflags!': [
600 # Clang's -mstackrealign doesn't work well with
601 # linux_syscall_support.h hand written asm syscalls.
602 # See https://crbug.com/556393
603 '-mstackrealign',
604 ],
605 }],
598 ], 606 ],
599 607
600 'include_dirs': [ 608 'include_dirs': [
601 'src', 609 'src',
602 'src/client', 610 'src/client',
603 'src/third_party/linux/include', 611 'src/third_party/linux/include',
604 '..', 612 '..',
605 '.', 613 '.',
606 ], 614 ],
607 }, 615 },
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 'sources': [ 705 'sources': [
698 'src/common/android/breakpad_getcontext_unittest.cc', 706 'src/common/android/breakpad_getcontext_unittest.cc',
699 ], 707 ],
700 'variables': { 708 'variables': {
701 'test_type': 'gtest', 709 'test_type': 'gtest',
702 'test_suite_name': '<(_target_name)', 710 'test_suite_name': '<(_target_name)',
703 'isolate_file': 'breakpad_unittests.isolate', 711 'isolate_file': 'breakpad_unittests.isolate',
704 }, 712 },
705 'includes': [ '../build/android/test_runner.gypi' ], 713 'includes': [ '../build/android/test_runner.gypi' ],
706 }], 714 }],
715 ['clang==1 and target_arch=="ia32"', {
716 'cflags!': [
717 # Clang's -mstackrealign doesn't work well with
718 # linux_syscall_support.h hand written asm syscalls.
719 # See https://crbug.com/556393
720 '-mstackrealign',
721 ],
722 }],
707 ], 723 ],
708 }, 724 },
709 { 725 {
710 # GN version: //breakpad:linux_dumper_unittest_helper 726 # GN version: //breakpad:linux_dumper_unittest_helper
711 'target_name': 'linux_dumper_unittest_helper', 727 'target_name': 'linux_dumper_unittest_helper',
712 'type': 'executable', 728 'type': 'executable',
713 'dependencies': [ 729 'dependencies': [
714 'breakpad_processor_support', 730 'breakpad_processor_support',
715 ], 731 ],
716 'sources': [ 732 'sources': [
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 'breakpad_unittests_apk.isolate', 1016 'breakpad_unittests_apk.isolate',
1001 ], 1017 ],
1002 }, 1018 },
1003 ] 1019 ]
1004 } 1020 }
1005 ], 1021 ],
1006 ], 1022 ],
1007 }], 1023 }],
1008 ], 1024 ],
1009 } 1025 }
OLDNEW
« no previous file with comments | « breakpad/BUILD.gn ('k') | components/crash.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698