Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5213)

Unified Diff: breakpad/BUILD.gn

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added bug reference in comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | breakpad/breakpad.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 233c5971598836d7834ca50e350680729aae781c..f3cf53a034cab938eea45f717cee3b1b96a64270 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -545,6 +545,13 @@ if (is_linux || is_android) {
cflags = [ "-marm" ]
}
+ if (current_cpu == "x86" && is_clang) {
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ cflags -= [ "-mstackrealign" ]
+ }
+
if (is_android) {
sources += [ "src/common/android/breakpad_getcontext.S" ]
}
@@ -650,6 +657,13 @@ if (is_linux || is_android) {
libs = [ "log" ]
include_dirs += [ "src/common/android/include" ]
}
+
+ if (current_cpu == "x86" && is_clang) {
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ cflags -= [ "-mstackrealign" ]
+ }
}
executable("linux_dumper_unittest_helper") {
« no previous file with comments | « no previous file | breakpad/breakpad.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698