components/crash.gypi - Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash.gypi

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added bug reference in comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash.gypi

diff --git a/components/crash.gypi b/components/crash.gypi

index 21af3bcb69523103d7af0b372063251aa8f5baf8..8b528fdb46ad06cd7c99408fdfd8a0c8cffa7feb 100644

--- a/components/crash.gypi

+++ b/components/crash.gypi

@@ -159,6 +159,14 @@

'../breakpad/src',

}],

+ ['clang==1 and target_arch=="ia32"', {

+ 'cflags!': [

+ # Clang's -mstackrealign doesn't work well with

+ # linux_syscall_support.h hand written asm syscalls.

+ # See https://crbug.com/556393

+ '-mstackrealign',

+ ],

+ }],

'target_conditions': [

# Need 'target_conditions' to override default filename_rules to include

« no previous file with comments | « breakpad/breakpad.gyp ('k') | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »