Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1473173004: Change the test tab load observer to print a clearer error message. (Closed)

Created:
5 years ago by Ted C
Modified:
5 years ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the test tab load observer to print a clearer error message. Updates the observer used in android instrumentation tests to print a nicer error message if the page did not load. BUG= Committed: https://crrev.com/ec9e287121770b172f29cfe57582f58b11b6b6c8 Cr-Commit-Position: refs/heads/master@{#361450}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years ago (2015-11-24 20:43:28 UTC) #2
gone
lgtm
5 years ago (2015-11-24 20:45:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473173004/1
5 years ago (2015-11-24 21:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 21:36:57 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-24 21:37:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec9e287121770b172f29cfe57582f58b11b6b6c8
Cr-Commit-Position: refs/heads/master@{#361450}

Powered by Google App Engine
This is Rietveld 408576698