chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java - Issue 1473173004: Change the test tab load observer to print a clearer error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

Issue 1473173004: Change the test tab load observer to print a clearer error message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

index 434745b3e310ed6ba789e36a349cd16227c311d3..672c12f045c52c0d35acb8f267f3bc584f220ec9 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java

@@ -57,8 +57,8 @@ public class NavigateTest extends ChromeTabbedActivityTestBase {

private void navigateAndObserve(final String startUrl, final String endUrl)

throws InterruptedException {

- assertTrue(CriteriaHelper.pollForUIThreadCriteria(

- new TabLoadObserver(getActivity().getActivityTab(), startUrl)));

+ new TabLoadObserver(getActivity().getActivityTab(), startUrl).assertLoaded();

assertTrue(CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

@Override

public boolean isSatisfied() {

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java » ('j') | no next file with comments »