chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java - Issue 1473173004: Change the test tab load observer to print a clearer error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

Issue 1473173004: Change the test tab load observer to print a clearer error message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

index ad72f51ebe2a689601485cae578864090aae1297..7cb2600b211897224691d6a089ae48a57f797b96 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

@@ -409,9 +409,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {

toggleTabSwitcher(false);

// Load another URL.

- final TabLoadObserver observer =

- new TabLoadObserver(getActivity().getActivityTab(), PAGE_2_HTML);

- assertTrue(CriteriaHelper.pollForUIThreadCriteria(observer));

+ new TabLoadObserver(getActivity().getActivityTab(), PAGE_2_HTML).assertLoaded();

// Bring the tab switcher forward and check the title.

toggleTabSwitcher(true);