chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java - Issue 1473173004: Change the test tab load observer to print a clearer error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

Issue 1473173004: Change the test tab load observer to print a clearer error message. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

index f9f03d73b2cdce3a45c9fb5aaa599de6ad3acc21..40564203b6ae80272af8838cb4b761268b6536b1 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelperTest.java

@@ -8,7 +8,6 @@ import android.content.Context;

import android.content.Intent;

import android.graphics.Bitmap;

import android.test.suitebuilder.annotation.SmallTest;

-import android.text.TextUtils;

import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

@@ -219,16 +218,7 @@ public class AddToHomescreenDialogHelperTest extends ChromeActivityTestCaseBase<

private void addShortcutToURL(String url, final String expectedPageTitle, final String title)

throws InterruptedException {

final Tab activeTab = mActivity.getActivityTab();

- TabLoadObserver observer = new TabLoadObserver(activeTab, url) {

- @Override

- public boolean isSatisfied() {

- // The page title is often updated over several iterations. Wait until the right

- // one appears.

- return super.isSatisfied()

- && TextUtils.equals(activeTab.getTitle(), expectedPageTitle);

- }

- };

- assertTrue(CriteriaHelper.pollForUIThreadCriteria(observer));

+ new TabLoadObserver(activeTab, url, expectedPageTitle, null).assertLoaded();

// Add the shortcut.

Callable<AddToHomescreenDialogHelper> callable =