create new Dart specific completion contributor extension point

create new Dart specific completion contributor extension point
and modify DartCompletionManager to use it

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/0168336439221c07ca792f8a461bacd17ba9c4cd

[danrubel, 2015-11-24 20:40:47]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[danrubel, 2015-11-24 20:40:47]

https://codereview.chromium.org/1470373002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1470373002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:217:
dartCompletionContributorExtensionPoint.extensions;
Yes, this is formatted. If you have suggestions for shorter names....

[scheglov, 2015-11-24 21:00:50]

LGTM

[danrubel, 2015-11-24 21:12:59]

Committed patchset #3 (id:40001) manually as
0168336439221c07ca792f8a461bacd17ba9c4cd (presubmit successful).

[Brian Wilkerson, 2015-11-24 21:31:25]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-11-24 21:31:25]

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:45:
AnalysisServer get server;
Why do we need the server to be accessible through the request?

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:50:
ServerPlugin get serverPlugin;
I don't think we actually want the server plugin to be made public. I assume
you're doing this so that third-party contributors can get their extensions, but
I think those third-party contributors should define their own plugin if they're
going to be pluggable.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
(right):

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:7: *
Dart specific completion contributors.
"new code Dart specific"? Remove "code"?

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:10: *
The registered contributor factoriess will be used to instantiate new
"factoriess" --> "factories"

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:14: * If
a plugin wants to add completions, it should implement the class
"implement the class"? DartCompletionContributorFactory is a function type
alias, not a class.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:24: *   
       () => [new MyDartCompletionContributor()]);
The documentation below (and the implementation of
_validateDartCompletionContributorExtension) says the value should be a
DartCompletionContributor. Is this example wrong, or should it be a list of
contributors? (Personal preference: make it a single object. Plugins can always
have more than one call to registerExtension.)

[danrubel, 2015-11-24 22:24:52]

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
(right):

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:45:
AnalysisServer get server;
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> Why do we need the server to be accessible through the request?

We need the resourceProvider and the serverPlugins, but not server.
I'll remove this.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:50:
ServerPlugin get serverPlugin;
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> I don't think we actually want the server plugin to be made public. I assume
> you're doing this so that third-party contributors can get their extensions,
but
> I think those third-party contributors should define their own plugin if
they're
> going to be pluggable.

The DartCompletionContributor is currently defined in ServerPlugin, but I'll
look into moving that code into a new DartCompletionPlugin just as if it were
contributed via a third party.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
File pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
(right):

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:7: *
Dart specific completion contributors.
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> "new code Dart specific"? Remove "code"?

Done.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:10: *
The registered contributor factoriess will be used to instantiate new
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> "factoriess" --> "factories"

Done.

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:14: * If
a plugin wants to add completions, it should implement the class
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> "implement the class"? DartCompletionContributorFactory is a function type
> alias, not a class.

Good eyes. Fixed

https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:24: *   
       () => [new MyDartCompletionContributor()]);
On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> The documentation below (and the implementation of
> _validateDartCompletionContributorExtension) says the value should be a
> DartCompletionContributor. Is this example wrong, or should it be a list of
> contributors? (Personal preference: make it a single object. Plugins can
always
> have more than one call to registerExtension.)

As currently defined, the factory instantiates a list of contributors, because
that was most useful for me to define all of the Dart specific completion
contributors that I provide by default. That said, I'll change it to a single
contributor.

[danrubel, 2015-11-30 17:51:31]

On 2015/11/24 22:24:52, danrubel wrote:
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> File pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
> (right):
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:45:
> AnalysisServer get server;
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > Why do we need the server to be accessible through the request?
> 
> We need the resourceProvider and the serverPlugins, but not server.
> I'll remove this.
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/completion_core.dart:50:
> ServerPlugin get serverPlugin;
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > I don't think we actually want the server plugin to be made public. I assume
> > you're doing this so that third-party contributors can get their extensions,
> but
> > I think those third-party contributors should define their own plugin if
> they're
> > going to be pluggable.
> 
> The DartCompletionContributor is currently defined in ServerPlugin, but I'll
> look into moving that code into a new DartCompletionPlugin just as if it were
> contributed via a third party.
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> File pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
> (right):
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:7: *
> Dart specific completion contributors.
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > "new code Dart specific"? Remove "code"?
> 
> Done.
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:10: *
> The registered contributor factoriess will be used to instantiate new
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > "factoriess" --> "factories"
> 
> Done.
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:14: *
If
> a plugin wants to add completions, it should implement the class
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > "implement the class"? DartCompletionContributorFactory is a function type
> > alias, not a class.
> 
> Good eyes. Fixed
> 
>
https://codereview.chromium.org/1470373002/diff/40001/pkg/analysis_server/lib...
> pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart:24: * 
 
>        () => [new MyDartCompletionContributor()]);
> On 2015/11/24 21:31:25, Brian Wilkerson wrote:
> > The documentation below (and the implementation of
> > _validateDartCompletionContributorExtension) says the value should be a
> > DartCompletionContributor. Is this example wrong, or should it be a list of
> > contributors? (Personal preference: make it a single object. Plugins can
> always
> > have more than one call to registerExtension.)
> 
> As currently defined, the factory instantiates a list of contributors, because
> that was most useful for me to define all of the Dart specific completion
> contributors that I provide by default. That said, I'll change it to a single
> contributor.

The above should all be addressed by 
https://codereview.chromium.org/1484853002/