create new Dart specific completion contributor extension point

pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

Index: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
index 7af0ab09bf29702341caac685f1d0416772de8e9..5158e6024ae00b161e2dd83d77a2d5200a826c0d 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
@@ -7,6 +7,8 @@ library analysis_server.src.provisional.completion.completion_core;
 import 'dart:async';
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
+import 'package:analysis_server/src/analysis_server.dart';
+import 'package:analysis_server/src/plugin/server_plugin.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
 import 'package:analyzer/src/generated/source.dart';
@@ -38,6 +40,16 @@ abstract class CompletionContributor {
  */
 abstract class CompletionRequest {
   /**
+   * Return the underlying analysis server for this completion request.
+   */
+  AnalysisServer get server;

[Brian Wilkerson, 2015/11/24 21:31:25]

Why do we need the server to be accessible through the request?

[danrubel, 2015/11/24 22:24:51]

We need the resourceProvider and the serverPlugins, but not server.
I'll remove this.

+
+  /**
+   * Return the [AnalysisServer]'s [ServerPlugin] for obtaining extensions
+   */
+  ServerPlugin get serverPlugin;

[Brian Wilkerson, 2015/11/24 21:31:25]

I don't think we actually want the server plugin to be made public. I assume
you're doing this so that third-party contributors can get their extensions, but
I think those third-party contributors should define their own plugin if they're
going to be pluggable.

[danrubel, 2015/11/24 22:24:51]

The DartCompletionContributor is currently defined in ServerPlugin, but I'll
look into moving that code into a new DartCompletionPlugin just as if it were
contributed via a third party.

+
+  /**
    * Return the analysis context in which the completion is being requested.
    */
   AnalysisContext get context;