pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart - Issue 1470373002: create new Dart specific completion contributor extension point

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart

Issue 1470373002: create new Dart specific completion contributor extension point (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart ('K') | « pkg/analysis_server/lib/src/services/completion/dart/inherited_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart b/pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart

index a653bbf3003b1b201845291f9c04b8aa46633c15..57beb276857e1b8aed0591155b32c1f9e90d655e 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart

@@ -8,7 +8,7 @@ library services.completion.dart.keyword;

import 'dart:async';

import 'package:analysis_server/plugin/protocol/protocol.dart';

-import 'package:analysis_server/src/provisional/completion/completion_dart.dart';

+import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';

import 'package:analyzer/src/generated/ast.dart';

import 'package:analyzer/src/generated/scanner.dart';

@@ -468,14 +468,8 @@ class _KeywordVisitor extends GeneralizingAstVisitor {

if (offset == null) {

offset = completion.length;

}

- suggestions.add(new CompletionSuggestion(

- CompletionSuggestionKind.KEYWORD,

- relevance,

- completion,

- offset,

- 0,

- false,

- false));

+ suggestions.add(new CompletionSuggestion(CompletionSuggestionKind.KEYWORD,

+ relevance, completion, offset, 0, false, false));

}

void _addSuggestions(List<Keyword> keywords,