create new Dart specific completion contributor extension point

pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Support for client code that extends the analysis server by adding new code
- * completion contributors.
+ * Dart specific completion contributors.

[Brian Wilkerson, 2015/11/24 21:31:25]

"new code Dart specific"? Remove "code"?

[danrubel, 2015/11/24 22:24:51]

Done.

  *
- * Plugins can register completion contributors. The registered contributors
- * will be used to get completions any time a client issues a
- * 'completion.getSuggestions' request.
+ * Plugins can register Dart specific completion contributor factories.
+ * The registered contributor factoriess will be used to instantiate new

[Brian Wilkerson, 2015/11/24 21:31:25]

"factoriess" --> "factories"

[danrubel, 2015/11/24 22:24:51]

Done.

+ * contributors to get completions any time a client issues
+ * a 'completion.getSuggestions' request.
  *
  * If a plugin wants to add completions, it should implement the class

[Brian Wilkerson, 2015/11/24 21:31:25]

"implement the class"? DartCompletionContributorFactory is a function type
alias, not a class.

[danrubel, 2015/11/24 22:24:51]

Good eyes. Fixed

- * [CompletionContributor] and then register the contributor by including code
- * like the following in the plugin's registerExtensions method:
+ * [DartCompletionContributorFactory] and then register the contributor
+ * by including code like the following in the plugin's
+ * registerExtensions method:
  *
  *     @override
  *     void registerExtensions(RegisterExtension registerExtension) {
  *       ...
  *       registerExtension(
- *           COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
- *           new MyCompletionContributor());
+ *           DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
+ *           () => [new MyDartCompletionContributor()]);

[Brian Wilkerson, 2015/11/24 21:31:25]

The documentation below (and the implementation of
_validateDartCompletionContributorExtension) says the value should be a
DartCompletionContributor. Is this example wrong, or should it be a list of
contributors? (Personal preference: make it a single object. Plugins can always
have more than one call to registerExtension.)

[danrubel, 2015/11/24 22:24:51]

As currently defined, the factory instantiates a list of contributors, because
that was most useful for me to define all of the Dart specific completion
contributors that I provide by default. That said, I'll change it to a single
contributor.

  *       ...
  *     }
  */
 library analysis_server.src.provisional.completion.completion;
 
 import 'package:analysis_server/src/plugin/server_plugin.dart';
-import 'package:analysis_server/src/provisional/completion/completion_core.dart';
+import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
 import 'package:plugin/plugin.dart';
 
 /**
  * The identifier of the extension point that allows plugins to register code
  * completion contributors. The object used as an extension must be a
- * [CompletionContributor].
+ * [DartCompletionContributor].
  */
-final String COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID = Plugin.join(
+final String DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID = Plugin.join(
     ServerPlugin.UNIQUE_IDENTIFIER,
-    ServerPlugin.COMPLETION_CONTRIBUTOR_EXTENSION_POINT);
+    ServerPlugin.DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT);