YouCompleteMe Ninja integration should accept dirs named out_*

Earlier, the script looked for dirs named 'out' or 'out_*'.
Recently it started looking for 'out' following by an alphanumeric word
boundary. Python considers underscores as alphanumeric, so this
unfortunately broke the 'out_*' pattern.

BUG=

Committed: https://crrev.com/f7a91ff583e0e65341d48179830748b9c01dbb51
Cr-Commit-Position: refs/heads/master@{#361655}

[lstorset, 2015-11-23 13:30:28]

Description was changed from

==========
YouCompleteMe Ninja integration accepts dirs named out_*

Earlier, the script looked for dirs named 'out' or 'out_*'.
Recently it started looking for 'out' following by an alphanumeric word
boundary. Python considers underscores as alphanumeric, so this
unfortunately broke the 'out_*' pattern.

BUG=
==========

to

==========
YouCompleteMe Ninja integration accepts dirs named out_*

Earlier, the script looked for dirs named 'out' or 'out_*'.
Recently it started looking for 'out' following by an alphanumeric word
boundary. Python considers underscores as alphanumeric, so this
unfortunately broke the 'out_*' pattern.

BUG=
==========

[lstorset, 2015-11-23 13:30:28]

lstorset@opera.com changed reviewers:
+ asanka@chromium.org, eroman@chromium.org, scottmg@chromium.org

[lstorset, 2015-11-23 13:35:21]

Description was changed from

==========
YouCompleteMe Ninja integration accepts dirs named out_*

Earlier, the script looked for dirs named 'out' or 'out_*'.
Recently it started looking for 'out' following by an alphanumeric word
boundary. Python considers underscores as alphanumeric, so this
unfortunately broke the 'out_*' pattern.

BUG=
==========

to

==========
Earlier, the script looked for dirs named 'out' or 'out_*'.
Recently it started looking for 'out' following by an alphanumeric word
boundary. Python considers underscores as alphanumeric, so this
unfortunately broke the 'out_*' pattern.

BUG=
==========

[scottmg, 2015-11-23 17:42:57]

lgtm

[asanka, 2015-11-23 22:30:47]

Could you add a test? Make sure the PRESUBMIT.py doesn't exclude your test. The
PRESUBMIT specifically only runs the YCM config test and only when that file has
been modified.

[eroman, 2015-11-24 00:55:06]

LGTM.

+1 on adding a test

[lstorset, 2015-11-24 16:49:37]

On 2015/11/23 22:30:47, asanka wrote:
> Could you add a test? Make sure the PRESUBMIT.py doesn't exclude your test.
The
> PRESUBMIT specifically only runs the YCM config test and only when that file
has
> been modified.

I added a test and made it run when ninja_output.py was modified (I think that's
what you implied). Good thing you suggested that, because the original patch
would have caused a regression! (The Python regex documentation is incorrect:
character classes are not supported inside sets.)

[asanka, 2015-11-24 19:43:49]

LGTM. Thanks!

I'd prefer if there was a separate ninja_output_unittest.py. But it's a weak
preference unless we are also adding tests for the other build directory
selection heuristics.

[lstorset, 2015-11-25 14:27:09]

Thanks for reviewing!

On 2015/11/24 19:43:49, asanka wrote:
> I'd prefer if there was a separate ninja_output_unittest.py. But it's a weak
> preference unless we are also adding tests for the other build directory
> selection heuristics.

Agreed. Also, a separate fixture would ease testing of more combinations. But I
won't spend time on that now.

[lstorset, 2015-11-25 14:28:26]

The CQ bit was checked by lstorset@opera.com

[lstorset, 2015-11-25 14:28:26]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org,
scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1469023002/#ps20001
(title: "Fixed regression, add test, include ninja_output.py in PRESUBMIT")

[commit-bot: I haz the power, 2015-11-25 14:28:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469023002/20001

[commit-bot: I haz the power, 2015-11-25 14:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 14:28:58]

The author lstorset@opera.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[lstorset, 2015-11-25 14:58:35]

The CQ bit was checked by lstorset@opera.com

[commit-bot: I haz the power, 2015-11-25 14:59:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469023002/20001

[commit-bot: I haz the power, 2015-11-25 15:11:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 15:12:23]

Patchset 2 (id:??) landed as
https://crrev.com/f7a91ff583e0e65341d48179830748b9c01dbb51
Cr-Commit-Position: refs/heads/master@{#361655}