Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: tools/vim/tests/chromium.ycm_extra_conf_unittest.py

Issue 1469023002: YouCompleteMe Ninja integration should accept dirs named out_* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed regression, add test, include ninja_output.py in PRESUBMIT Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/vim/ninja_output.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/vim/tests/chromium.ycm_extra_conf_unittest.py
diff --git a/tools/vim/tests/chromium.ycm_extra_conf_unittest.py b/tools/vim/tests/chromium.ycm_extra_conf_unittest.py
index 303207055f7bbc6462a03ff0635699ae8b110d7d..d0a555851d93c4996ce9d5be748115b8cfbcce5a 100755
--- a/tools/vim/tests/chromium.ycm_extra_conf_unittest.py
+++ b/tools/vim/tests/chromium.ycm_extra_conf_unittest.py
@@ -163,6 +163,18 @@ class Chromium_ycmExtraConfTest(unittest.TestCase):
'-I[OUT]/tag-one'
])
+ def testOutDirNames(self):
+ out_root = os.path.join(self.chrome_root, 'out_with_underscore')
+ out_dir = os.path.join(out_root, 'Debug')
+ shutil.move(os.path.join(self.chrome_root, 'out'),
+ out_root)
+
+ clang_options = \
+ self.ycm_extra_conf.GetClangOptionsFromNinjaForFilename(
+ self.chrome_root, os.path.join(self.chrome_root, 'one.cpp'))
+ self.assertIn('-I%s/a' % out_dir, clang_options)
+ self.assertIn('-I%s/tag-one' % out_dir, clang_options)
+
def testGetFlagsForFileForKnownCppFile(self):
result = self.ycm_extra_conf.FlagsForFile(
os.path.join(self.chrome_root, 'one.cpp'))
« no previous file with comments | « tools/vim/ninja_output.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698