tools/vim/ninja_output.py - Issue 1469023002: YouCompleteMe Ninja integration should accept dirs named out_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/vim/ninja_output.py

Issue 1469023002: YouCompleteMe Ninja integration should accept dirs named out_* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed regression, add test, include ninja_output.py in PRESUBMIT Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/vim/ninja_output.py

diff --git a/tools/vim/ninja_output.py b/tools/vim/ninja_output.py

index fab26eb53b65b50562054c2b0cb2a71a48c377f9..5bb638ab6d96676c368d8e5afcc81e4f7ceba308 100644

--- a/tools/vim/ninja_output.py

+++ b/tools/vim/ninja_output.py

@@ -40,7 +40,7 @@ def GetNinjaOutputDirectory(chrome_root, configuration=None):

output_dirs = [name_value[1]]

if not output_dirs:

for f in os.listdir(chrome_root):

- if re.match(r'out\b', f):

+ if re.match(r'out(\b|_)', f):

out = os.path.realpath(os.path.join(chrome_root, f))

if os.path.isdir(out):

output_dirs.append(os.path.relpath(out, start = chrome_root))

« no previous file with comments | « tools/vim/PRESUBMIT.py ('k') | tools/vim/tests/chromium.ycm_extra_conf_unittest.py » ('j') | no next file with comments »