tools/vim/PRESUBMIT.py - Issue 1469023002: YouCompleteMe Ninja integration should accept dirs named out_*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/vim/PRESUBMIT.py

Issue 1469023002: YouCompleteMe Ninja integration should accept dirs named out_* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed regression, add test, include ninja_output.py in PRESUBMIT Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/vim/PRESUBMIT.py

diff --git a/tools/vim/PRESUBMIT.py b/tools/vim/PRESUBMIT.py

index 0456d37e86b253b1657275063c4ff16af79aadc6..33cdd6d82bc4b80468b15d9f0d983acb892d35a1 100644

--- a/tools/vim/PRESUBMIT.py

+++ b/tools/vim/PRESUBMIT.py

@@ -21,6 +21,7 @@ def CheckChangeOnUpload(input_api, output_api):

# test requires access to 'ninja' and hasn't been tested on platforms other

# than Linux.

if 'chromium.ycm_extra_conf.py' in affected_files or \

+ 'ninja_output.py' in affected_files or \

any([input_api.re.match(r'tests(/|\\)',f) for f in affected_files]):

results += input_api.RunTests(

input_api.canned_checks.GetUnitTests(

« no previous file with comments | « no previous file | tools/vim/ninja_output.py » ('j') | no next file with comments »