Make IFWL_Target::m_pImpl a private member.

Make IFWL_Target::m_pImpl a private member.

Remove pointless subclass dtors since CFWL_TargetImpl
has a virtual dtor, and can be deleted by the base
class.

Kept pointless subclass ctors for the moment to hopefully
combine with Initialize someday, though they need not do
anything since the base class ctor nulls out m_pImpl.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/3fc8c688374fc8f34f4b02debc5888e2775df91b

[Tom Sepez, 2015-11-18 22:09:31]

Description was changed from

==========
Make IFWL_Target::m_pImpl a private member.

Remove pointless subclass dtors since CFWL_TargetImpl
has a virtual dtor, and can be deleted by the base
class.

Kept pointless subclass ctors for the moment to hopefully
combine with Initialize someday.
==========

to

==========
Make IFWL_Target::m_pImpl a private member.

Remove pointless subclass dtors since CFWL_TargetImpl
has a virtual dtor, and can be deleted by the base
class.

Kept pointless subclass ctors for the moment to hopefully
combine with Initialize someday, though they need not do
anything since the base class ctor nulls out m_pImpl.
==========

[Tom Sepez, 2015-11-18 22:09:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-11-18 22:15:21]

Lei, for review.

[Lei Zhang, 2015-11-18 23:26:20]

https://codereview.chromium.org/1460883002/diff/1/xfa/src/fwl/src/core/fwl_ta...
File xfa/src/fwl/src/core/fwl_targetimp.cpp (right):

https://codereview.chromium.org/1460883002/diff/1/xfa/src/fwl/src/core/fwl_ta...
xfa/src/fwl/src/core/fwl_targetimp.cpp:39: delete m_pImpl;
Is |m_pImpl| suppose to be Release()'d like on line 10 or deleted? Should we
assert the refcount in ~IFWL_Target ?

[Tom Sepez, 2015-11-18 23:36:28]

>
https://codereview.chromium.org/1460883002/diff/1/xfa/src/fwl/src/core/fwl_ta...
> xfa/src/fwl/src/core/fwl_targetimp.cpp:39: delete m_pImpl;
> Is |m_pImpl| suppose to be Release()'d like on line 10 or deleted? Should we
> assert the refcount in ~IFWL_Target ?
That's the question raised in the other CL about the non-incrementing refcounts.
 When we know the answer to that, we'll just remove one or the other.  But for
now I want to make equivalent code.

[Lei Zhang, 2015-11-18 23:38:14]

On 2015/11/18 23:36:28, Tom Sepez wrote:
> >
>
https://codereview.chromium.org/1460883002/diff/1/xfa/src/fwl/src/core/fwl_ta...
> > xfa/src/fwl/src/core/fwl_targetimp.cpp:39: delete m_pImpl;
> > Is |m_pImpl| suppose to be Release()'d like on line 10 or deleted? Should we
> > assert the refcount in ~IFWL_Target ?
> That's the question raised in the other CL about the non-incrementing
refcounts.
>  When we know the answer to that, we'll just remove one or the other.  But for
> now I want to make equivalent code.

Ok, lgtm.

[Tom Sepez, 2015-11-18 23:55:26]

Committed patchset #1 (id:1) manually as
3fc8c688374fc8f34f4b02debc5888e2775df91b (presubmit successful).