Make IFWL_Target::m_pImpl a private member.

xfa/src/fwl/src/core/fwl_panelimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "include/fwl_targetimp.h"
 #include "include/fwl_noteimp.h"
 #include "include/fwl_widgetimp.h"
 #include "include/fwl_panelimp.h"
 IFWL_Panel* IFWL_Panel::Create() {
   return new IFWL_Panel;
 }
 FWL_ERR IFWL_Panel::Initialize(IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_PanelImp(pOuter);
-  ((CFWL_PanelImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_PanelImp*)m_pImpl)->Initialize();
+  CFWL_PanelImp* pPanelImpl = new CFWL_PanelImp(pOuter);
+  SetImpl(pPanelImpl);
+  pPanelImpl->SetInterface(this);
+  return pPanelImpl->Initialize();
 }
 FWL_ERR IFWL_Panel::Initialize(CFWL_WidgetImpProperties& properties,
                                IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_PanelImp(properties, pOuter);
-  ((CFWL_PanelImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_PanelImp*)m_pImpl)->Initialize();
+  CFWL_PanelImp* pPanelImpl = new CFWL_PanelImp(properties, pOuter);
+  SetImpl(pPanelImpl);
+  pPanelImpl->SetInterface(this);
+  return pPanelImpl->Initialize();
 }
 IFWL_Content* IFWL_Panel::GetContent() {
-  return ((CFWL_PanelImp*)m_pImpl)->GetContent();
+  return static_cast<CFWL_PanelImp*>(GetImpl())->GetContent();
 }
 FWL_ERR IFWL_Panel::SetContent(IFWL_Content* pContent) {
-  return ((CFWL_PanelImp*)m_pImpl)->SetContent(pContent);
+  return static_cast<CFWL_PanelImp*>(GetImpl())->SetContent(pContent);
 }
 IFWL_Panel::IFWL_Panel() {
-  m_pImpl = NULL;
-}
-IFWL_Panel::~IFWL_Panel() {
-  if (m_pImpl) {
-    delete (CFWL_PanelImp*)m_pImpl;
-    m_pImpl = NULL;
-  }
 }
 CFWL_PanelImp::CFWL_PanelImp(IFWL_Widget* pOuter)
     : CFWL_WidgetImp(pOuter), m_pContent(NULL) {}
 CFWL_PanelImp::CFWL_PanelImp(const CFWL_WidgetImpProperties& properties,
                              IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter), m_pContent(NULL) {}
 CFWL_PanelImp::~CFWL_PanelImp() {}
 FWL_ERR CFWL_PanelImp::GetClassName(CFX_WideString& wsClass) const {
   wsClass = FWL_CLASS_Panel;
   return FWL_ERR_Succeeded;
@@ skipping 85 matching lines @@
   return pContent->SetParent(m_pInterface);
 }
 FWL_ERR CFWL_CustomPanelImp::SetProxy(IFWL_Proxy* pProxy) {
   m_pProxy = pProxy;
   return FWL_ERR_Succeeded;
 }
 IFWL_CustomPanel* IFWL_CustomPanel::Create() {
   return new IFWL_CustomPanel;
 }
 FWL_ERR IFWL_CustomPanel::Initialize(IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_CustomPanelImp(pOuter);
-  ((CFWL_CustomPanelImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_CustomPanelImp*)m_pImpl)->Initialize();
+  CFWL_CustomPanelImp* pCustomPanelImpl = new CFWL_CustomPanelImp(pOuter);
+  SetImpl(pCustomPanelImpl);
+  pCustomPanelImpl->SetInterface(this);
+  return pCustomPanelImpl->Initialize();
 }
 FWL_ERR IFWL_CustomPanel::Initialize(CFWL_WidgetImpProperties& properties,
                                      IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_CustomPanelImp(properties, pOuter);
-  ((CFWL_CustomPanelImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_CustomPanelImp*)m_pImpl)->Initialize();
+  CFWL_CustomPanelImp* pCustomPanelImpl =
+      new CFWL_CustomPanelImp(properties, pOuter);
+  SetImpl(pCustomPanelImpl);
+  pCustomPanelImpl->SetInterface(this);
+  return pCustomPanelImpl->Initialize();
 }
 IFWL_Content* IFWL_CustomPanel::GetContent() {
-  return ((CFWL_CustomPanelImp*)m_pImpl)->GetContent();
+  return static_cast<CFWL_CustomPanelImp*>(GetImpl())->GetContent();
 }
 FWL_ERR IFWL_CustomPanel::SetContent(IFWL_Content* pContent) {
-  return ((CFWL_CustomPanelImp*)m_pImpl)->SetContent(pContent);
+  return static_cast<CFWL_CustomPanelImp*>(GetImpl())->SetContent(pContent);
 }
 FWL_ERR IFWL_CustomPanel::SetProxy(IFWL_Proxy* pProxy) {
-  return ((CFWL_CustomPanelImp*)m_pImpl)->SetProxy(pProxy);
+  return static_cast<CFWL_CustomPanelImp*>(GetImpl())->SetProxy(pProxy);
 }
 IFWL_CustomPanel::IFWL_CustomPanel() {
-  m_pImpl = NULL;
 }
-IFWL_CustomPanel::~IFWL_CustomPanel() {
-  if (m_pImpl) {
-    delete (CFWL_CustomPanelImp*)m_pImpl;
-    m_pImpl = NULL;
-  }
-}