Make IFWL_Target::m_pImpl a private member.

xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../core/include/fwl_targetimp.h"
 #include "../core/include/fwl_noteimp.h"
 #include "../core/include/fwl_widgetimp.h"
 #include "../core/include/fwl_panelimp.h"
 #include "../core/include/fwl_formimp.h"
 #include "../core/include/fwl_widgetmgrimp.h"
 #include "include/fwl_formproxyimp.h"
 #include "include/fwl_editimp.h"
 #include "include/fwl_monthcalendarimp.h"
 #include "include/fwl_datetimepickerimp.h"
 #define FWL_DTP_WIDTH 100
 #define FWL_DTP_HEIGHT 20
 IFWL_DateTimePicker* IFWL_DateTimePicker::Create() {
   return new IFWL_DateTimePicker;
 }
 FWL_ERR IFWL_DateTimeForm::Initialize(
     const CFWL_WidgetImpProperties& properties,
     IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_FormProxyImp(properties, pOuter);
-  ((CFWL_FormProxyImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_FormProxyImp*)m_pImpl)->Initialize();
+  CFWL_FormProxyImp* pFormProxyImpl = new CFWL_FormProxyImp(properties, pOuter);
+  SetImpl(pFormProxyImpl);
+  pFormProxyImpl->SetInterface(this);
+  return pFormProxyImpl->Initialize();
 }
 FWL_ERR IFWL_DateTimeCalender::Initialize(
     const CFWL_WidgetImpProperties& properties,
     IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_DateTimeCalendar(properties, pOuter);
-  ((CFWL_DateTimeCalendar*)m_pImpl)->SetInterface(this);
-  return ((CFWL_DateTimeCalendar*)m_pImpl)->Initialize();
+  CFWL_DateTimeCalendar* pDateTimeCalendarImpl =
+      new CFWL_DateTimeCalendar(properties, pOuter);
+  SetImpl(pDateTimeCalendarImpl);
+  pDateTimeCalendarImpl->SetInterface(this);
+  return pDateTimeCalendarImpl->Initialize();
 }
 FWL_ERR IFWL_DateTimeEdit::Initialize(
     const CFWL_WidgetImpProperties& properties,
     IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_DateTimeEdit(properties, pOuter);
-  ((CFWL_DateTimeEdit*)m_pImpl)->SetInterface(this);
-  return ((CFWL_DateTimeEdit*)m_pImpl)->Initialize();
+  CFWL_DateTimeEdit* pDateTimeEditImpl =
+      new CFWL_DateTimeEdit(properties, pOuter);
+  SetImpl(pDateTimeEditImpl);
+  pDateTimeEditImpl->SetInterface(this);
+  return pDateTimeEditImpl->Initialize();
 }
 IFWL_DateTimePicker::IFWL_DateTimePicker() {
-  m_pImpl = NULL;
-}
-IFWL_DateTimePicker::~IFWL_DateTimePicker() {
-  if (m_pImpl) {
-    delete (CFWL_DateTimePickerImp*)m_pImpl;
-    m_pImpl = NULL;
-  }
 }
 FWL_ERR IFWL_DateTimePicker::Initialize(IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_DateTimePickerImp(pOuter);
-  ((CFWL_DateTimePickerImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Initialize();
+  CFWL_DateTimePickerImp* pDateTimePickerImpl =
+      new CFWL_DateTimePickerImp(pOuter);
+  SetImpl(pDateTimePickerImpl);
+  pDateTimePickerImpl->SetInterface(this);
+  return pDateTimePickerImpl->Initialize();
 }
 FWL_ERR IFWL_DateTimePicker::Initialize(
     const CFWL_WidgetImpProperties& properties,
     IFWL_Widget* pOuter) {
-  m_pImpl = new CFWL_DateTimePickerImp(properties, pOuter);
-  ((CFWL_DateTimePickerImp*)m_pImpl)->SetInterface(this);
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Initialize();
+  CFWL_DateTimePickerImp* pDateTimePickerImpl =
+      new CFWL_DateTimePickerImp(properties, pOuter);
+  SetImpl(pDateTimePickerImpl);
+  pDateTimePickerImpl->SetInterface(this);
+  return pDateTimePickerImpl->Initialize();
 }
 int32_t IFWL_DateTimePicker::CountSelRanges() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
       ->GetDataTimeEdit()
       ->CountSelRanges();
 }
 int32_t IFWL_DateTimePicker::GetSelRange(int32_t nIndex, int32_t& nStart) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
       ->GetDataTimeEdit()
       ->GetSelRange(nIndex, nStart);
 }
 FWL_ERR IFWL_DateTimePicker::GetCurSel(int32_t& iYear,
                                        int32_t& iMonth,
                                        int32_t& iDay) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->GetCurSel(iYear, iMonth, iDay);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
+      ->GetCurSel(iYear, iMonth, iDay);
 }
 FWL_ERR IFWL_DateTimePicker::SetCurSel(int32_t iYear,
                                        int32_t iMonth,
                                        int32_t iDay) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->SetCurSel(iYear, iMonth, iDay);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
+      ->SetCurSel(iYear, iMonth, iDay);
 }
 FWL_ERR IFWL_DateTimePicker::SetEditText(const CFX_WideString& wsText) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->SetEditText(wsText);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->SetEditText(wsText);
 }
 FWL_ERR IFWL_DateTimePicker::GetEditText(CFX_WideString& wsText,
                                          int32_t nStart,
                                          int32_t nCount) const {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
       ->GetEditText(wsText, nStart, nCount);
 }
 FX_BOOL IFWL_DateTimePicker::CanUndo() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->CanUndo();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->CanUndo();
 }
 FX_BOOL IFWL_DateTimePicker::CanRedo() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->CanRedo();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->CanRedo();
 }
 FX_BOOL IFWL_DateTimePicker::Undo() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Undo();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Undo();
 }
 FX_BOOL IFWL_DateTimePicker::Redo() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Redo();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Redo();
 }
 FX_BOOL IFWL_DateTimePicker::CanCopy() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->CanCopy();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->CanCopy();
 }
 FX_BOOL IFWL_DateTimePicker::CanCut() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->CanCut();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->CanCut();
 }
 FX_BOOL IFWL_DateTimePicker::CanSelectAll() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->CanSelectAll();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->CanSelectAll();
 }
 FX_BOOL IFWL_DateTimePicker::Copy(CFX_WideString& wsCopy) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Copy(wsCopy);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Copy(wsCopy);
 }
 FX_BOOL IFWL_DateTimePicker::Cut(CFX_WideString& wsCut) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Cut(wsCut);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Cut(wsCut);
 }
 FX_BOOL IFWL_DateTimePicker::Paste(const CFX_WideString& wsPaste) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Paste(wsPaste);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Paste(wsPaste);
 }
 FX_BOOL IFWL_DateTimePicker::SelectAll() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->SelectAll();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->SelectAll();
 }
 FX_BOOL IFWL_DateTimePicker::Delete() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->Delete();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->Delete();
 }
 FX_BOOL IFWL_DateTimePicker::DeSelect() {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->DeSelect();
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->DeSelect();
 }
 FWL_ERR IFWL_DateTimePicker::GetBBox(CFX_RectF& rect) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->GetBBox(rect);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->GetBBox(rect);
 }
 FWL_ERR IFWL_DateTimePicker::SetEditLimit(int32_t nLimit) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)->SetEditLimit(nLimit);
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())->SetEditLimit(nLimit);
 }
 FWL_ERR IFWL_DateTimePicker::ModifyEditStylesEx(FX_DWORD dwStylesExAdded,
                                                 FX_DWORD dwStylesExRemoved) {
-  return ((CFWL_DateTimePickerImp*)m_pImpl)
+  return static_cast<CFWL_DateTimePickerImp*>(GetImpl())
       ->ModifyEditStylesEx(dwStylesExAdded, dwStylesExRemoved);
 }
 CFWL_DateTimeEdit::CFWL_DateTimeEdit(const CFWL_WidgetImpProperties& properties,
                                      IFWL_Widget* pOuter)
     : CFWL_EditImp(properties, pOuter) {}
 FWL_ERR CFWL_DateTimeEdit::Initialize() {
   m_pDelegate = (IFWL_WidgetDelegate*)new CFWL_DateTimeEditImpDelegate(this);
   _FWL_ERR_CHECK_RETURN_VALUE_IF_FAIL(CFWL_EditImp::Initialize(),
                                       FWL_ERR_Indefinite);
   return FWL_ERR_Succeeded;
@@ skipping 1008 matching lines @@
     }
     if (m_pOwner->m_pEdit->GetStates() & FWL_WGTSTATE_Focused) {
       pMsg->m_pSrcTarget = m_pOwner->m_pEdit;
       IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
       pDelegate->OnProcessMessage(pMsg);
     }
   }
   rtInvalidate.Inflate(2, 2);
   m_pOwner->Repaint(&rtInvalidate);
 }