xfa/src/fwl/src/core/include/fwl_targetimp.h - Issue 1460883002: Make IFWL_Target::m_pImpl a private member.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/core/include/fwl_targetimp.h

Issue 1460883002: Make IFWL_Target::m_pImpl a private member. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/core/include/fwl_targetimp.h

diff --git a/xfa/src/fwl/src/core/include/fwl_targetimp.h b/xfa/src/fwl/src/core/include/fwl_targetimp.h

index 87ae8ea390f776f078378ebfa38ea12d2189fbc7..5f494a78e2d4fd6c3b422d15552b5953b3b265a8 100644

--- a/xfa/src/fwl/src/core/include/fwl_targetimp.h

+++ b/xfa/src/fwl/src/core/include/fwl_targetimp.h

@@ -12,6 +12,8 @@

class CFWL_TargetImp {

public:

+ virtual ~CFWL_TargetImp();

virtual FX_DWORD Release();

virtual IFWL_Target* Retain();

virtual FX_DWORD GetRefCount() const;

@@ -23,7 +25,6 @@ class CFWL_TargetImp {

protected:

CFWL_TargetImp();

- virtual ~CFWL_TargetImp();

FX_DWORD m_dwRefCount;

};