Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1460523005: Add MVN (register, immediate) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -30 lines) Patch
M src/DartARM32/assembler_arm.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 5 chunks +31 lines, -16 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A tests_lit/assembler/arm32/mvn.ll View 1 chunk +145 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
Karl
5 years, 1 month ago (2015-11-19 17:13:45 UTC) #3
John
lgtm
5 years, 1 month ago (2015-11-19 17:46:04 UTC) #4
Karl
Committed patchset #1 (id:1) manually as e559be77b93bdfa5b0877455f012219aa426f10f (presubmit successful).
5 years, 1 month ago (2015-11-20 22:26:15 UTC) #5
Jim Stichnoth
https://codereview.chromium.org/1460523005/diff/1/tests_lit/assembler/arm32/mvn.ll File tests_lit/assembler/arm32/mvn.ll (right): https://codereview.chromium.org/1460523005/diff/1/tests_lit/assembler/arm32/mvn.ll#newcode21 tests_lit/assembler/arm32/mvn.ll:21: define internal void @mvmEx(i32 %a, i32 %b) { Should ...
5 years, 1 month ago (2015-11-22 04:15:39 UTC) #6
Karl
5 years ago (2015-11-30 16:54:11 UTC) #7
Message was sent while issue was closed.
Fixed in CL https://codereview.chromium.org/1484023002.

https://codereview.chromium.org/1460523005/diff/1/tests_lit/assembler/arm32/m...
File tests_lit/assembler/arm32/mvn.ll (right):

https://codereview.chromium.org/1460523005/diff/1/tests_lit/assembler/arm32/m...
tests_lit/assembler/arm32/mvn.ll:21: define internal void @mvmEx(i32 %a, i32 %b)
{
On 2015/11/22 04:15:38, stichnot wrote:
> Should this be named mvnEx instead?

Done.

Powered by Google App Engine
This is Rietveld 408576698