Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1459653002: Gets mustash frames looking like that of ash (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gets mustash frames looking like that of ash This is basically a fork of various portions of ash frame code. I left parts we have no support for yet out, but kept some things that we'll need to support eventually. BUG=548426 TEST=none R=ben@chromium.org Committed: https://crrev.com/afeecbf9c6549bdfb0e00492d206f47a3088b40f Cr-Commit-Position: refs/heads/master@{#360501}

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : merge to master #

Patch Set 4 : merge to tip of tree #

Patch Set 5 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+848 lines, -1092 lines) Patch
M mash/wm/BUILD.gn View 1 2 3 5 chunks +44 lines, -7 lines 0 comments Download
A mash/wm/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + mash/wm/frame/caption_buttons/caption_button_types.h View 2 chunks +8 lines, -6 lines 0 comments Download
A + mash/wm/frame/caption_buttons/frame_caption_button.h View 4 chunks +13 lines, -16 lines 0 comments Download
A + mash/wm/frame/caption_buttons/frame_caption_button.cc View 7 chunks +21 lines, -19 lines 0 comments Download
A + mash/wm/frame/caption_buttons/frame_caption_button_container_view.h View 4 chunks +22 lines, -51 lines 0 comments Download
A + mash/wm/frame/caption_buttons/frame_caption_button_container_view.cc View 11 chunks +55 lines, -141 lines 0 comments Download
A + mash/wm/frame/default_header_painter.h View 4 chunks +13 lines, -15 lines 0 comments Download
A + mash/wm/frame/default_header_painter.cc View 12 chunks +70 lines, -75 lines 0 comments Download
A mash/wm/frame/frame_border_hit_test_controller.h View 1 chunk +40 lines, -0 lines 0 comments Download
A + mash/wm/frame/frame_border_hit_test_controller.cc View 3 chunks +23 lines, -26 lines 0 comments Download
A + mash/wm/frame/header_painter.h View 2 chunks +13 lines, -15 lines 0 comments Download
A + mash/wm/frame/header_painter_util.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + mash/wm/frame/header_painter_util.cc View 3 chunks +7 lines, -24 lines 0 comments Download
A + mash/wm/frame/move_loop.h View 3 chunks +9 lines, -3 lines 0 comments Download
A + mash/wm/frame/move_loop.cc View 3 chunks +7 lines, -1 line 0 comments Download
A + mash/wm/frame/move_loop_unittest.cc View 1 2 3 4 3 chunks +7 lines, -1 line 0 comments Download
A mash/wm/frame/non_client_frame_view_mash.h View 1 chunk +107 lines, -0 lines 0 comments Download
A mash/wm/frame/non_client_frame_view_mash.cc View 1 chunk +351 lines, -0 lines 0 comments Download
D mash/wm/move_loop.h View 1 chunk +0 lines, -115 lines 0 comments Download
D mash/wm/move_loop.cc View 1 chunk +0 lines, -223 lines 0 comments Download
D mash/wm/move_loop_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M mash/wm/non_client_frame_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 3 chunks +10 lines, -4 lines 0 comments Download
D mash/wm/non_client_frame_view_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mash/wm/non_client_frame_view_impl.cc View 1 chunk +0 lines, -101 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_impl.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
sky
5 years, 1 month ago (2015-11-18 19:21:10 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 1 month ago (2015-11-18 20:46:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459653002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459653002/40001
5 years, 1 month ago (2015-11-18 21:38:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/15636)
5 years, 1 month ago (2015-11-18 21:48:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459653002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459653002/60001
5 years, 1 month ago (2015-11-18 23:20:00 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/68634)
5 years, 1 month ago (2015-11-18 23:53:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1459653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1459653002/80001
5 years, 1 month ago (2015-11-19 00:12:35 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-19 02:42:12 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:43:06 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/afeecbf9c6549bdfb0e00492d206f47a3088b40f
Cr-Commit-Position: refs/heads/master@{#360501}

Powered by Google App Engine
This is Rietveld 408576698