Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2052)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455833005: Convert ConnectToApplication to take a params class (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, yzshen+watch_chromium.org, sadrul, mlamouri+watch-test-runner_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, jam, feature-media-reviews_chromium.org, dcheng, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, tfarina, jochen+watch_chromium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ConnectToApplication to take a params class R=sky@chromium.org BUG=none Committed: https://crrev.com/a5404b52abc4d9008c0a5e48f7cb9488895462f9 Cr-Commit-Position: refs/heads/master@{#360954}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Patch Set 16 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -181 lines) Patch
M components/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/devtools_service/devtools_http_server.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 chunk +1 line, -4 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -3 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -5 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M components/html_viewer/global_state.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +1 line, -5 lines 0 comments Download
M components/html_viewer/html_widget.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/html_viewer/layout_test_html_viewer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/html_viewer/stats_collection_controller.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M components/resource_provider/public/cpp/resource_loader.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/web_view/frame_connection.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/web_view/frame_devtools_agent.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M device/devices_app/devices_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M mash/wm/window_manager_apptest.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M media/mojo/services/media_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +1 line, -8 lines 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M mojo/application/public/cpp/application_impl.h View 1 2 3 4 5 6 3 chunks +28 lines, -8 lines 0 comments Download
M mojo/application/public/cpp/lib/application_impl.cc View 1 2 3 4 5 6 4 chunks +14 lines, -12 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gyp View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/runner/child/native_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M mojo/services/test_service/test_service_impl.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M sql/mojo/sql_test_base.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sql/mojo/vfs_unittest.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 65 (37 generated)
Ben Goodger (Google)
5 years, 1 month ago (2015-11-18 22:37:39 UTC) #1
sky
LGTM
5 years, 1 month ago (2015-11-18 22:41:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/60001
5 years, 1 month ago (2015-11-19 16:16:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/96690) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-19 16:25:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/80001
5 years, 1 month ago (2015-11-19 18:38:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/125487) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-19 18:41:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/100001
5 years, 1 month ago (2015-11-19 19:05:15 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/98498)
5 years, 1 month ago (2015-11-19 19:15:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/120001
5 years, 1 month ago (2015-11-19 20:06:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/109303)
5 years, 1 month ago (2015-11-19 20:23:52 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/140001
5 years, 1 month ago (2015-11-19 20:27:27 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/87635)
5 years, 1 month ago (2015-11-19 20:45:36 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/160001
5 years, 1 month ago (2015-11-20 00:44:42 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/69322)
5 years, 1 month ago (2015-11-20 01:38:52 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/180001
5 years, 1 month ago (2015-11-20 03:45:34 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/200001
5 years, 1 month ago (2015-11-20 03:53:43 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/143712)
5 years, 1 month ago (2015-11-20 05:07:25 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/210001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/210001
5 years, 1 month ago (2015-11-20 05:14:11 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/143723)
5 years, 1 month ago (2015-11-20 05:29:46 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/230001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/230001
5 years, 1 month ago (2015-11-20 05:34:26 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/143344)
5 years, 1 month ago (2015-11-20 05:48:30 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/240001
5 years, 1 month ago (2015-11-20 15:16:19 UTC) #53
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/16660) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 1 month ago (2015-11-20 15:20:11 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/260001
5 years, 1 month ago (2015-11-20 15:27:33 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/143887)
5 years, 1 month ago (2015-11-20 16:57:22 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455833005/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455833005/280001
5 years, 1 month ago (2015-11-20 22:31:17 UTC) #63
commit-bot: I haz the power
Committed patchset #16 (id:280001)
5 years, 1 month ago (2015-11-20 23:49:14 UTC) #64
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 23:50:11 UTC) #65
Message was sent while issue was closed. 
Patchset 16 (id:??) landed as
https://crrev.com/a5404b52abc4d9008c0a5e48f7cb9488895462f9
Cr-Commit-Position: refs/heads/master@{#360954}

Powered by Google App Engine
This is Rietveld 408576698