Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: mojo/shell/capability_filter_test.cc

Issue 1455833005: Convert ConnectToApplication to take a params class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/capability_filter_test.cc
diff --git a/mojo/shell/capability_filter_test.cc b/mojo/shell/capability_filter_test.cc
index b50f7174dd817fc0bdad75755834a264c4e2211e..1b55759d5472a07978c934280d7e4a3e16459952 100644
--- a/mojo/shell/capability_filter_test.cc
+++ b/mojo/shell/capability_filter_test.cc
@@ -118,9 +118,7 @@ class ServiceApplication : public ApplicationDelegate,
app_ = app;
// ServiceApplications have no capability filter and can thus connect
// directly to the validator application.
- URLRequestPtr request(URLRequest::New());
- request->url = String::From("test:validator");
- app_->ConnectToService(request.Pass(), &validator_);
+ app_->ConnectToService("test:validator", &validator_);
}
bool ConfigureIncomingConnection(ApplicationConnection* connection) override {
AddService<Safe>(connection);
@@ -170,16 +168,12 @@ bool TestApplication::ConfigureIncomingConnection(
// TestApplications receive their Validator via the inbound connection.
connection->ConnectToService(&validator_);
- URLRequestPtr request(URLRequest::New());
- request->url = String::From("test:service");
- connection1_ = app_->ConnectToApplication(request.Pass());
+ connection1_ = app_->ConnectToApplication("test:service");
connection1_->SetRemoteServiceProviderConnectionErrorHandler(
base::Bind(&TestApplication::ConnectionClosed,
base::Unretained(this), "test:service"));
- URLRequestPtr request2(URLRequest::New());
- request2->url = String::From("test:service2");
- connection2_ = app_->ConnectToApplication(request2.Pass());
+ connection2_ = app_->ConnectToApplication("test:service2");
connection2_->SetRemoteServiceProviderConnectionErrorHandler(
base::Bind(&TestApplication::ConnectionClosed,
base::Unretained(this), "test:service2"));
« no previous file with comments | « mojo/shell/application_manager_unittest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698