components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc - Issue 1455833005: Convert ConnectToApplication to take a params class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

Issue 1455833005: Convert ConnectToApplication to take a params class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/stats_collection_controller.cc ('k') | components/mus/public/cpp/lib/window_tree_host_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

diff --git a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

index a99b9c82913df83793e55fb997de0395e4d7c20d..862d54c5ccfe9a92a59a1cd88aa80445052cfdf5 100644

--- a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

+++ b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc

@@ -34,10 +34,8 @@ WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(

gl_info->rendererInfo = gpu_info->renderer_info.To<blink::WebString>();

gl_info->driverVersion = gpu_info->driver_version.To<blink::WebString>();

- mojo::URLRequestPtr request(mojo::URLRequest::New());

- request->url = mojo::String::From("mojo:mus");

mus::mojom::GpuPtr gpu_service;

- app->ConnectToService(request.Pass(), &gpu_service);

+ app->ConnectToService("mojo:mus", &gpu_service);

mus::mojom::CommandBufferPtr cb;

gpu_service->CreateOffscreenGLES2Context(GetProxy(&cb));

return new WebGraphicsContext3DCommandBufferImpl(

« no previous file with comments | « components/html_viewer/stats_collection_controller.cc ('k') | components/mus/public/cpp/lib/window_tree_host_factory.cc » ('j') | no next file with comments »