Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: components/html_viewer/ax_provider_apptest.cc

Issue 1455833005: Convert ConnectToApplication to take a params class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/DEPS ('k') | components/html_viewer/blink_platform_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/ax_provider_apptest.cc
diff --git a/components/html_viewer/ax_provider_apptest.cc b/components/html_viewer/ax_provider_apptest.cc
index 431356e9075607a61f8b062d44837cef9f0814b6..fa04062368355c2f225b5dc09a35545f1483ba46 100644
--- a/components/html_viewer/ax_provider_apptest.cc
+++ b/components/html_viewer/ax_provider_apptest.cc
@@ -14,6 +14,7 @@
#include "components/web_view/public/interfaces/frame.mojom.h"
#include "mojo/application/public/cpp/application_impl.h"
#include "mojo/application/public/cpp/application_test_base.h"
+#include "mojo/converters/network/network_type_converters.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/mojo_services/src/accessibility/public/interfaces/accessibility.mojom.h"
@@ -77,12 +78,9 @@ TEST_F(AXProviderTest, HelloWorld) {
ASSERT_TRUE(server.Start());
// Connect to the URL through the mojo:html_viewer content handler.
- const uint16_t assigned_port = server.host_port_pair().port();
- mojo::URLRequestPtr request(mojo::URLRequest::New());
- request->url = mojo::String::From(
- base::StringPrintf("http://127.0.0.1:%u/test.html", assigned_port));
scoped_ptr<ApplicationConnection> connection =
- application_impl()->ConnectToApplication(request.Pass());
+ application_impl()->ConnectToApplication(
+ server.GetURL("/test.html").spec());
// Embed the html_viewer in a Window.
mus::mojom::WindowTreeClientPtr tree_client;
« no previous file with comments | « components/html_viewer/DEPS ('k') | components/html_viewer/blink_platform_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698