Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all" (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

chromium_tests: do not add crash_service to compile targets if they already contain "all" See https://groups.google.com/a/chromium.org/d/msg/infra-dev/vAZjvj8xKgU/HZvIWj20BgAJ for context. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -61 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg.json View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg.json View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel.json View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel_analyze.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg.json View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json View 2 chunks +2 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel.json View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel_analyze.json View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-17 14:01:13 UTC) #2
Nico
lgtm, thanks!
5 years, 1 month ago (2015-11-17 15:02:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455563003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455563003/1
5 years, 1 month ago (2015-11-18 08:16:03 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 08:22:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297592

Powered by Google App Engine
This is Rietveld 408576698