scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json - Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json

Issue 1455563003: chromium_tests: do not add crash_service to compile targets if they already contain "all" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg.json ('k') | scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json

index 82f11af3c0eaa5cf809eb1e2eb40905cab91764e..6fad53e2970ccfab2df95dff351b21318cb98ed7 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json

@@ -208,7 +208,7 @@

"win_clang_x64_dbg",

"-v",

"//out/Debug_x64",

- "{\"additional_compile_targets\": [\"all\", \"crash_service\"], \"files\": [\"foo.cc\"], \"test_targets\": []}",

+ "{\"additional_compile_targets\": [\"all\"], \"files\": [\"foo.cc\"], \"test_targets\": []}",

"/path/to/tmp/json"

"cwd": "[SLAVE_BUILD]",

@@ -223,8 +223,7 @@

"@@@STEP_LOG_END@json.output@@@",

"@@@STEP_LOG_LINE@analyze_details@{@@@",

"@@@STEP_LOG_LINE@analyze_details@ \"additional_compile_targets\": [@@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"all\", @@@",

- "@@@STEP_LOG_LINE@analyze_details@ \"crash_service\"@@@",

+ "@@@STEP_LOG_LINE@analyze_details@ \"all\"@@@",

"@@@STEP_LOG_LINE@analyze_details@ ], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"compile_targets\": [], @@@",

"@@@STEP_LOG_LINE@analyze_details@ \"self.m.filter.compile_targets\": [], @@@",